-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new Discord username #1397
Conversation
I don't like how this is implemented; I think we should add a formatting function somewhere that will handle the logic, and then use the formatted output anywhere we need the username |
discord will force all user to use new username, so we don't need to check username anymore :) |
Either way I think it would still be good to make a specific formatting function for usernames. Discrims will still exist for a bit longer (this would be a future-proof solution) and then it becomes easier to make other formatting changes in the future (for example, showing display name instead of username, or showing a combination of them). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new formatUsername
utility is missing usage in 2 places:
+"** "+(rm.getOwner() == 0L ? "(autoplay)" : "(requested by **" + rm.user.username + "**)")); |
+ "** " + (rm.getOwner() == 0L ? "(autoplay)" : "(requested by **" + rm.user.username + "**)"); |
… metadata UserInfo, add null check
* Support new username * Support new username, again * Make a separate username formatting function * Add some missing usage * switch away from using static imports, add shortcuts for jda User and metadata UserInfo, add null check --------- Co-authored-by: unknown <john.a.grosh@gmail.com>
This pull request...
Description
A easy way to support Discord new username(maybe
Purpose