-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the configuration section explicit about all run modes #379
Conversation
Merge upstream
…ly jboss-tck-runner example Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Ladicek feel free to add any comments if you think this doesn't address it sufficiently. |
I'm seeing that the config example for the Core profile is excluding the following: |
Yes, and the core profile TCK includes an appropriate TestNG suite file that already has this configured, so you could just run using the suite.xml without any excluded group specified: |
I think @breakponchito highlights that there's an inconsistency between the text and the XML snippet. Which is fair I think, we should update the text. |
<groups>se,arquillian</groups> | ||
<dependenciesToScan> | ||
<dependency>jakarta.enterprise:cdi-tck-core-impl</dependency> | ||
</configuration> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This snippet misses one line to close the element:
</dependenciesToScan>
before the line 152
</configuration>
Addresses #378