https://github.com/jakartaee/faces/issues/1765 #1767
Conversation
Add missing waitForBackgroundJavaScript calls
arjantijms
added
the
TCK
| @@ -101,6 +100,7 @@ private void testSingleSelection(String form) throws Exception { | |||
| input.setValueAttribute(file.getAbsolutePath()); | |||
|
|
|||
| page = page.getHtmlElementById(form + ":submit").click(); | |||
| webClient.waitForBackgroundJavaScript(3000); | |||
There was a problem hiding this comment.
I'm not sure if the waitForBackgroundJavaScript method is smart enough to not wait if there are no background javascript functions. If it isn't then I would suggest introducing a boolean flag that will allow us to dynamically wait depending on the test case.
Otherwise, we are waiting for no reason.
There was a problem hiding this comment.
I'll take your word for it and approve the PR if you think waitForBackgroundJavaScript is smart enough.
There was a problem hiding this comment.
Yes. Moreover, I already ran it locally. And it also exists in a bunch of other tests. Note that it also waits for any non-ajax scripts to load completely, e.g. onload/deferred/async scripts.
|
Thanks for getting this fix put in. |
|
You're explicitly requested as reviewer. |
Fixes #1765 Add missing waitForBackgroundJavaScript calls