Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 3 #63

Merged
merged 6 commits into from
Apr 27, 2017
Merged

Milestone 3 #63

merged 6 commits into from
Apr 27, 2017

Conversation

bparish628
Copy link
Collaborator

This is essentially the same thing as Milestone 2 because not a whole lot has changed. I just added the walkthrough and the repo issues section.

@bparish628 bparish628 requested a review from jakeharding April 26, 2017 20:54
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.362% when pulling 1d47a47 on milestone-3 into b7cd7b5 on dev.

Copy link
Owner

@jakeharding jakeharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I have a couple comments, but I can make those additions and add the url for the repo I posted issues to. I'll have an update soon.


The current state of the system is in a proof of concept and is not ready for a production environment. The proof of concept supplies basic statistics about a repository and leaves out complex data manipulation.

Rendering of charts has been left out in this milestone but the data is still present in the user interface as a list of numbers.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this line.


The intent is to provide the user with usable information about a GitHub repository so the user can make an informed decision about the health and sustainability of the repository and the community supporting it.

The system has many parts. The backend provides a connection to the database, serialization of the data, and serving the data to the client in JSON format. The web client uses the JSON data to render the visualization of the data. Both parts are included in the source code repository for convenience, but the system is built so the separation of the frontend and backend can be easily achieved.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add something about Docker here?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.362% when pulling 68fb3b3 on milestone-3 into b7cd7b5 on dev.

Copy link
Owner

@jakeharding jakeharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with it. 😁

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.362% when pulling 13a8bf8 on milestone-3 into b7cd7b5 on dev.

@jakeharding jakeharding merged commit c137b7d into dev Apr 27, 2017
@jakeharding jakeharding deleted the milestone-3 branch April 27, 2017 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants