Add intl extension

[benr77]

Latest version of Rector complains about missing intl extension. I would consider it reasonable to add this to the PHP builds.

Notice: RectorPrefix20210124\Nette\Utils\Strings::toAscii(): it is recommended to enable PHP extensions 'intl'. in /tools/.composer/vendor-bin/rector/vendor/rector/rector-prefixed/vendor/nette/utils/src/Utils/Strings.php on line 124

[jakzal]

Thanks for this. Looks like the resulting image won't increase in size much.

However, the way to make this change as per CONTRIBUTING guidelines is to:

• Make changes to both Debian and Alpine docker file templates (Dockerfile-debian and Dockerfile-alpine). Once you made your changes, regenerate docker files with make generate.

[jakzal]

Actually, the reason I didn't notice the image size change is because build regenerates Docker files, so your changes were not applied.

I see you updated them already, let's see how it goes now.

[jakzal]

You'll need to add the ICU library toLIB_DEPS in both Docker files.

I think on Debian the package is called libicu-dev while on Alpine it's icu-dev.

[jakzal]

Difference in size is:

• Debian 608MB vs 654MB
• Alpine 250MB vs 290MB

[benr77]

Yes, I've just seen the final build sizes. What do you think? Too much overhead?

[jakzal]

@dkarlovi suggested to me it's used often enough to warrant the increase in size.

Let's get it merged. First, though, I need to make sure the build will still pass after the merge. Seems there are some issues with php-cs-fixer on PHP 8 again.

[jakzal]

@benr77 I had to revert the merge as docker hub builds started to fail with:

Debian:

checking for icu-uc >= 50.1 icu-io icu-i18n...
no
�[91mconfigure: error: Package requirements (icu-uc >= 50.1 icu-io icu-i18n) were not met:
No package 'icu-uc' found
No package 'icu-io' found
No package 'icu-i18n' found
Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.
Alternatively, you may set the environment variables ICU_CFLAGS
and ICU_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.

and Alpine:

checking for location of ICU headers and libraries... checking for pkg-config... /usr/bin/pkg-config
checking for icu-config...
no
not found
�[91mconfigure: error: Unable to detect ICU prefix or no failed. Please verify ICU install prefix and make sure icu-config works.

Can you reopen the PR please?

[benr77]

What do I do to do that? Push more changes to my branch?

[jakzal]

Try rebasing with latest master maybe.