Skip to content

Support secrets manager #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2022
Merged

Support secrets manager #44

merged 2 commits into from
Oct 12, 2022

Conversation

sgomez17
Copy link
Contributor

@sgomez17 sgomez17 commented Aug 4, 2022

Changes:

  • Ability to fetch DB details/credentials from AWS SecretsManager when SECRETS_MANAGER_SECRET_ID is supplied.

jameshy
jameshy approved these changes Oct 12, 2022
View reviewed changes
Copy link
Owner

@jameshy jameshy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jameshy jameshy merged commit e3d16e4 into jameshy:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jameshy jameshy jameshy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sgomez17 @jameshy