Node 18.* Runtime Compatibility #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AWS runtimes (18.*, 20.*) Also run `npm audit fix` to update deps Working on Node 16.* and 18.* runtimes. The binaries don't work on 20.*, so this isn't quite up to latest, but at least 18.* isn't EOL.
|
This works perfectly, thank you!! |
|
Thanks @scosman ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #63
Add aws-sdk as a regular dependency (not dev), since it isn't bundled in newer AWS runtimes (18., 20.).
Also run
npm audit fixto update deps.Working on Node 16.* and 18.* runtimes. The binaries don't work on 20., so this isn't quite up to latest, but at least 18. isn't EOL.
Note: since I updated readme to suggest 18.* I'd suggest only merging once your ready to publish a release.