You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For nan_treatment == 'fill' in convolve(), since any and all possibel NaN values are removed, the subsequent npy_isnan(val), for example for boundary=None (the default), in the Cython routine boundary_none.pyx can be removed. Removing this is a step closer to removing all conditionals such that vectorization can take place.
The text was updated successfully, but these errors were encountered:
jamienoss
changed the title
Dedup Nan conditionals
Dedup NaN conditionals
Jan 29, 2018
jamienoss
changed the title
Dedup NaN conditionals
Dedupe NaN conditionals
Jan 29, 2018
Dedupe NaN conditionals
src
To prevent possible duplicated work when
preserve_nan == True and nan_treatment == 'fill'
the condtions should be joined:nan_treatment == 'fill'
For
nan_treatment == 'fill'
in convolve(), since any and all possibelNaN
values are removed, the subsequentnpy_isnan(val)
, for example forboundary=None
(the default), in the Cython routine boundary_none.pyx can be removed. Removing this is a step closer to removing all conditionals such that vectorization can take place.The text was updated successfully, but these errors were encountered: