Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test errors due to unsupported features of USB 6002 device #7

Closed
Cody-G opened this issue Jun 22, 2017 · 3 comments
Closed

Test errors due to unsupported features of USB 6002 device #7

Cody-G opened this issue Jun 22, 2017 · 3 comments

Comments

@Cody-G
Copy link
Contributor

Cody-G commented Jun 22, 2017

I just discovered that digital input, output, and counter tests fail for my USB 6002 device. The digital io failures seem to happen because this device doesn't support buffered digital io. The counter test fails because the device doesn't have any counter channels, and the check for that in the tests doesn't quite work as intended. I have fixes that I can submit as a PR after #6 merges.
@bjarthur
Copy link
Collaborator

i'd be happy to review a PR that fixes this.

@Cody-G
Copy link
Contributor Author

Cody-G commented Jun 24, 2017

Great, I just opened #8

@bjarthur
Copy link
Collaborator

bjarthur commented Aug 1, 2017

fixed by #8

@bjarthur bjarthur closed this as completed Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bjarthur @Cody-G