Fix token auth (instead of setting headers) #31
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19, #27 and #30. Also makes #15 obsolete.
I noticed that token auth wasn't working and having my password in plain text isn't an option.
Seems like
Object.assign
throws the errorCannot convert undefined or null to object
becauseoptions.headers
wasn't defined before. But i decided, instead of setting the headers to empty object above (like #15 does), using theoptions.auth
to keep it consistent.The code for token auth previously must have been missed that part when updating to
options.auth
.The failure grabbed from VSCode Extension Host Logs was