fix(package): inicializo variable attempts antes de ejecutar el metod… #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansanchez
added a commit
that referenced
this pull request
Mar 11, 2016
fix(package): inicializo variable attempts antes de ejecutar el metod…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
El problema consistía que al ejecutar el versionado, en algunos casos no terminaba de compilar.
Investigando encontré que en la función
Execute.prototype.readFiledel archivoexecute.js, se ejecuta unwhiledonde aumentaba la variablethis.attempts++y este mismo arrojó como valorNaN, debido a que no se inicializó antes.Por ello inicializo la variable con cero para poder ejecutar correctamente la función.
this.attempts = 0;en la funciónExecute.prototype.runCommand