Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken with upcoming nightly #227

Closed
jethrogb opened this issue Dec 13, 2018 · 11 comments
Closed

Broken with upcoming nightly #227

jethrogb opened this issue Dec 13, 2018 · 11 comments

Comments

@jethrogb
Copy link
Collaborator

Once a new nightly is produced, xargo will stop working because of rust-lang/rust#56092 . You can already see this behavior when using https://github.com/kennytm/rustup-toolchain-install-master

$ xargo build --target x86_64-fortanix-unknown-sgx
   Compiling core v0.0.0 (/home/jethro/.rustup/toolchains/9fe5cb5342244a716055fa0162e795deabd4985c/lib/rustlib/src/rust/src/libcore)
    Finished release [optimized] target(s) in 22.12s
error: failed to load source for a dependency on `compiler_builtins`

Caused by:
  Unable to update /home/jethro/.rustup/toolchains/9fe5cb5342244a716055fa0162e795deabd4985c/lib/rustlib/src/rust/src/libcompiler_builtins

Caused by:
  failed to read `/home/jethro/.rustup/toolchains/9fe5cb5342244a716055fa0162e795deabd4985c/lib/rustlib/src/rust/src/libcompiler_builtins/Cargo.toml`

Caused by:
  No such file or directory (os error 2)
error: `"cargo" "build" "--release" "--manifest-path" "/tmp/xargo.MmX2uglNXWpA/Cargo.toml" "--target" "x86_64-fortanix-unknown-sgx" "-p" "compiler_builtins"` failed with exit code: Some(101)
note: run with `RUST_BACKTRACE=1` for a backtrace
`` 
@jethrogb
Copy link
Collaborator Author

Once a new nightly is produced

Yay we finally got a new nightly 🎉 Boo, xargo is now broken 😞

bjorn3 added a commit to rust-lang/rustc_codegen_cranelift that referenced this issue Dec 15, 2018
It is currently broken. (see japaric/xargo#227)

This makes it easier to for example patch whole crates away.
bjorn3 added a commit to rust-lang/rustc_codegen_cranelift that referenced this issue Dec 15, 2018
It is currently broken. (see japaric/xargo#227)

This makes it easier to for example patch whole crates away.
bjorn3 added a commit to rust-lang/rustc_codegen_cranelift that referenced this issue Dec 15, 2018
It is currently broken. (see japaric/xargo#227)

This makes it easier to for example patch whole crates away.
bjorn3 added a commit to rust-lang/rustc_codegen_cranelift that referenced this issue Dec 15, 2018
It is currently broken. (see japaric/xargo#227)

This makes it easier to for example patch whole crates away.
bors bot added a commit that referenced this issue Dec 15, 2018
228: Fix for latest nightly: need to add a patch section r=RalfJung a=RalfJung

Fixes #227

Co-authored-by: Ralf Jung <post@ralfj.de>
bors bot added a commit that referenced this issue Dec 15, 2018
228: Fix for latest nightly: need to add a patch section r=RalfJung a=RalfJung

Fixes #227

Co-authored-by: Ralf Jung <post@ralfj.de>
@bors bors bot closed this as completed in #228 Dec 15, 2018
@bruceloco
Copy link

Is this fixed in xargo 0.3.13?
I am trying for 3 days to build an arm-none-eabi for arm7 targets for kernel development and I am left scratching my head. First its create the target, its fun, but hard to find the info, then it fails because there are no binaries for it or libs even though you have the compiler(and this is in windows as well) then xargo shows as a suggestion and you move to nightly, and what not and the end result is this bug
If I wasnt a grown man I would cry :D

@RalfJung
Copy link
Collaborator

RalfJung commented Mar 8, 2019

Yeah this is long fixed. So if you have 0.3.13, whatever you are hitting is not this bug.

@jethrogb
Copy link
Collaborator Author

jethrogb commented Mar 8, 2019

Well, it's only fixed if you use the rust-src component or the XARGO_RUST_SRC envvar. If you use one of the other methods to specify the source, it's still broken. A PR has been open to fix that for a long time.

@bruceloco
Copy link

I am.on windows, I tried to pass that as a command line argument but it fails, also setting in the windows environment it also fails using set, haven't tried manually on the system settings
But the command line argument should work...

@jethrogb
Copy link
Collaborator Author

jethrogb commented Mar 8, 2019

@bruceloco There is no way to set the source using a command-line argument

@RalfJung
Copy link
Collaborator

RalfJung commented Mar 8, 2019

@jethrogb

Well, it's only fixed if you use the rust-src component or the XARGO_RUST_SRC envvar. If you use one of the other methods to specify the source, it's still broken. A PR has been open to fix that for a long time.

Fair. Xargo is unfortunately not maintained currently. But it seems like we both have an interest in it -- so how about we suggest to @japaric that we could co-maintain it? I basically care only about case of building a custom libstd for the host architecture, but xargo currently is the only tool I know of that can do that -- and it's not like I intend to break the cross-building part (and it seems you have some interest in that?). I also don't have much time to spare, so I won't be able to review anything big or go through the backlog of PRs or issues, but between the two of us it seems like we should be able to get stuff like your PR landed and keep xargo at the level of functionality it is at right now.

@jethrogb
Copy link
Collaborator Author

@RalfJung Sure I can review PRs that keep Xargo's pre-existing functionality working until Cargo can do this.

@robert-w-gries
Copy link

@RalfJung Have you looked into cargo-xbuild? It is an actively maintained fork of xargo

@RalfJung
Copy link
Collaborator

@robert-w-gries it cannot build libstd though, which I require.

@RalfJung
Copy link
Collaborator

@jethrogb

Sure I can review PRs that keep Xargo's pre-existing functionality working until Cargo can do this.

Okay, let's do this!

@japaric we'd like to take over basic maintenance of xargo, if that's okay for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants