Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hoistStatics #76

Merged
merged 1 commit into from
Jul 22, 2017
Merged

Fix hoistStatics #76

merged 1 commit into from
Jul 22, 2017

Conversation

apalm
Copy link
Contributor

@apalm apalm commented Jul 22, 2017 •
edited
Loading

1909ec9 added hoistStatics.tsx in lieu of hoist-non-react-statics. However, it appears that typos were made, judging by the hoist-non-react-statics source.

0.8.1 currently crashes in React Native without this fix.

@apalm apalm changed the title Fix typos Fix hoistStatics Jul 22, 2017
@jaredpalmer jaredpalmer merged commit d778d56 into jaredpalmer:master Jul 22, 2017
@jaredpalmer
Copy link
Owner

Thanks

@tlenclos
Copy link

tlenclos commented Aug 1, 2017

Hi there,
I am using the 0.8.8 version and it's crashing on Android.

Type error
hoistNonReactStatics
    formik.js:93:43
hoistNonReactStatics
    formik.js:82:37
wrapWithFormik
    formik.js:360:36
<unknown>
    SearchFilters.js:391:5
loadModuleImplementation

@jaredpalmer
Copy link
Owner

@tlenclos Let’s open up another issue for this

@tlenclos
Copy link

tlenclos commented Aug 1, 2017

@jaredpalmer Not the case anymore with the fix in v0.8.9 👍 (b38806c)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apalm @jaredpalmer @tlenclos