Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tsconfig.json not applied to test directory #225

Closed
third774 opened this issue Oct 5, 2019 · 1 comment · Fixed by #226
Closed

tsconfig.json not applied to test directory #225

third774 opened this issue Oct 5, 2019 · 1 comment · Fixed by #226
Labels
kind: feature New feature or request solution: duplicate This issue or pull request already exists

Comments

@third774
Copy link
Contributor

third774 commented Oct 5, 2019

Current Behavior

Currently the tsconfig.json file only lists ["src", "types"] in the include key, which leaves out the "test" folder. This means that VS Code doesn't use the tsconfig.json file for files in that directory. None of the strict rules are applied.

image

Expected behavior

Expected the tsconfig.json rules to also apply to test files

Suggested solution(s)

Add "test" to the include key

image

Additional context

Your environment

Software Version(s)
TSDX 0.9.3
TypeScript 3.6.2
Browser n/a
npm/Yarn 1.12.3
Operating System macOS Mojave 10.14.2
@third774 third774 mentioned this issue Oct 5, 2019
Merged
@agilgur5 agilgur5 mentioned this issue Mar 17, 2020
Closed
@agilgur5
Copy link
Collaborator

Turns out this was a duplicate of #84

@agilgur5 agilgur5 added the solution: duplicate This issue or pull request already exists label Mar 17, 2020
@agilgur5 agilgur5 changed the title tsconfig.json not applied to test files tsconfig.json not applied to test directory Mar 17, 2020
This was referenced Mar 27, 2020
Merged
Open
Closed
@agilgur5 agilgur5 added the kind: feature New feature or request label Sep 6, 2020
@agilgur5 agilgur5 mentioned this issue Sep 20, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: feature New feature or request solution: duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add "test" directory to template tsconfigs' includes third774/tsdx
2 participants
@agilgur5 @third774