Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update help channels to point to formium org #762

Merged
merged 2 commits into from
Jul 19, 2020
Merged

Update help channels to point to formium org #762

merged 2 commits into from
Jul 19, 2020

Conversation

jssee
Copy link
Contributor

@jssee jssee commented Jul 16, 2020

Currently, the URLs pointing to the repo/issues are not uniform or correct.
It's not a huge deal since it seems all redirects are current working correctly,
but consistency is nice

Copy link
Collaborator

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there's a second reference in messages.ts per #754 that should be changed too.

Also looks like the test failure is due to a lint issue from #734 , which hadn't run linting in CI for some reason so it managed to get past that check, sorry 😕

@jssee
Copy link
Contributor Author

jssee commented Jul 16, 2020

@agilgur5 good catch, updated!

@vercel
Copy link

vercel bot commented Jul 18, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/formium/tsdx/kgxwwa0sw
✅ Preview: https://tsdx-git-fork-jssee-master.formium.vercel.app

@jssee
Copy link
Contributor Author

jssee commented Jul 18, 2020

@agilgur5 i cant rebase and fix merge conflicts, i think it might have to do with permissions?

Copy link
Collaborator

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating and fixing!

@agilgur5
Copy link
Collaborator

@jssee ah so #765 introduced a conflict here.. Not sure what kind of error you're getting as command line git shouldn't normally give permissions errors. I also have no control over permissions in this repo in any case, so if that were actually the case, I wouldn't be able to resolve 😕

@jssee
Copy link
Contributor Author

jssee commented Jul 18, 2020

@agilgur5 no problem, i figured out what the conflict was, i was editing a page that no longer existed. I dropped that commit, hopefully this one is good to go

Copy link
Collaborator

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting errors here are not from this PR

@agilgur5 agilgur5 merged commit 25a39cc into jaredpalmer:master Jul 19, 2020
@agilgur5
Copy link
Collaborator

@allcontributors please add @jssee for code

@allcontributors
Copy link
Contributor

@agilgur5

I've put up a pull request to add @jssee! 🎉

paul-vd pushed a commit to EezyQuote/tsdx that referenced this pull request Dec 1, 2020
* update help channel URLs to point to formium org

* update point formik repo reference to formium
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants