Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no way out of <blockquote> #89

Open
okbel opened this issue Mar 9, 2018 · 9 comments
Open

There is no way out of <blockquote> #89

okbel opened this issue Mar 9, 2018 · 9 comments

Comments

@okbel
Copy link

okbel commented Mar 9, 2018

Once you click Quote it starts creating new <blockquote>s tags. I can't exit the quote while I'm typing. Even with double enters, or tab.

@jaredreich
Copy link
Owner

@okbel thanks very much for the feedback. Big update for pell coming soon with tons of fixes, hopefully I can work in a fix for this as well.

@okbel
Copy link
Author

okbel commented Mar 10, 2018

Thanks for the quick reply! (And sorry for the short description I wanted to comeback and write detailed steps of repro hah)

Really excited about the update! Let me know how it goes! We are using Pell for Talk here

@jaredreich
Copy link
Owner

jaredreich commented Mar 12, 2018

@okbel No worries. v1.0.1 includes a fix for the blockquote escaping, as well as making sure the first child element in the editor is properly wrapped in a tag (I noticed you have a workaround for this in this file:
https://github.com/coralproject/talk/blob/master/plugins/talk-plugin-rich-text-pell/client/utils.js
Perhaps you don't need the workaround anymore.

The coral project looks pretty cool, kudos to you and your team.

Maybe I can post a "Who uses pell" section on this README and list that project there. Let me know if you're okay with that.

@okbel
Copy link
Author

okbel commented Mar 12, 2018

Thank you! Sure! Feel free to add us to the section.

@nguyentranchung
Copy link

Was this problem relsoved? I'm using ver 1.0.4 but blockquote can't exit

@nguyentranchung
Copy link

Click quote button => input something => shift + enter => input something => enter => not escap (bug)

@jaredreich
Copy link
Owner

Interesting, never knew about the shift+enter thing.

@litemotiv
Copy link

I use the outdent execCommand to leave blockquotes, which seems to work well under all circumstances.

@RossMWoods
Copy link

I find blockquote very handy, but dont have them. My version is v2 working branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants