Skip to content

Conversation

btoews
Copy link
Contributor

@btoews btoews commented Aug 10, 2016

This PR fixes two bugs:

  • Whitespace wasn't allowed around the return type from a promise.
  • Dictionary members couldn't be prefixed with the required keyword.

These fixes allow this gem to parse the IDL from the Web Authentication spec.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 94.892% when pulling 7ebd05e on mastahyeti:master into 18cf050 on jarib:master.

@jarib
Copy link
Owner

jarib commented Aug 10, 2016

Thanks! It's been a while since the specs ran on Travis. If you rebase this against master the build should be fixed.

@coveralls
Copy link

coveralls commented Aug 10, 2016

Coverage Status

Coverage increased (+0.1%) to 94.892% when pulling 43c545d on mastahyeti:master into 81ca9e1 on jarib:master.

@jarib
Copy link
Owner

jarib commented Aug 10, 2016

Merged and released as 0.1.9.

@jarib jarib closed this Aug 10, 2016
@btoews
Copy link
Contributor Author

btoews commented Aug 10, 2016

🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants