ToDo list #1219
Comments
|
Regarding this issue, is it not more sensible to add a null character at the end to make |
|
What's the usecase here, just processing the selection in bash script? If that is indeed the usecase then you can manually append the null char at the end, no? { cat "$NNN_SEL" && printf '\0'; } | while read -d $'\0' ...I suppose something like this would work. Untested. |
|
Yes, there are many workarounds/solutions. My point was wouldn't it be simpler to make I actually manually added the null character like you mentioned but also wasn't confident this would not result in unexpected behavior. A familiar null-delimited If there are good reasons to omit the last null character then this is a non-issue. I don't have strong opinions on the matter, just felt like others might encounter this minor annoyance I had, especially when I couldn't find much info about |
|
NUL is used as a separator, not a terminator in the code. |
|
In troubleshooting section of wiki written:
Description confusing without context. What if call it e.g. a piped list or add example it will be much clearer? |
|
Could you please add a note/music file icon for |
|
When a file is deleted externally (not by plugin), nnn refreshes and cursor goes to the top. Is it possible to keep cursor at same position (or on the next file, if cursor was on file that was deleted) after it refreshes? |
|
First, this happens only when you are hovering on a file that's one of the deleted files. External directory change (including deletions) come as events. We do not distinguish between single and multiple events combined together. We don't want to go into every event and check if it's a deletion and the file is hovered and then process the next one and check if the next file is also deleted and so on. That's inefficient. If we don't find the hovered file on refresh we simply move to the top. |
|
Hi (and sorry for butting into the existing conversations--I figured this is a good place to brain dump on ideas), I'm considering writing a plugin called zoxide that simply calls zoxide for the user to quickly cd. I know there's already zoxide integration with autojump, but this would be more instant and fits the paradigm of these tools in that the user only has to execute one command to cd at the risk of going to the wrong directory. Is that something that you'd merge in? |
|
Please have a personal plugin of your own. It's too basic and a duplicate. |
|
Hmm it seems to be as basic as the gitroot plugin I just submitted. Also
how is it a duplicate? Do you mean of auto jump?
…On Fri, Dec 24, 2021 at 9:01 PM Arun ***@***.***> wrote:
Please have a personal plugin of your own. It's too basic and a duplicate.
—
Reply to this email directly, view it on GitHub
<#1219 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPAJECRP2TV4XLKL3VL47LUSVF25ANCNFSM5HLWMEEA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
In case I wasn't clear enough, it's not a duplicate of autojump because it wouldn't scan the data of zoxide and use fzf for the user to select a directory as autojump does. It would simply prompt the user for a directory string and pass it onto zoxide to cd. |
|
No separate plugin for directory jumps please. |
|
May I hear the reason why?
Anyway, another idea I had is making public the plugin for writing the
paths of the current selection to clipboard. Right now it’s undocumented in
the plugin readme and is hidden. But, as I pointed out in another issue,
sometimes people who want have the copy paths to clipboard functionality
separate from sending file manager notifications functionality. Or they
just want to only copy to clipboard on command. Both needs can be met if it
was a bonafide plugin that the user knows they can add to NNN_PLUG and
trigger on demand. And all we have to do is rename it and remove the dot
that denotes it as a helper plugin and also publicize it on the readme.
…On Sat, Dec 25, 2021 at 12:00 AM Arun ***@***.***> wrote:
No separate plugin for directory jumps please.
—
Reply to this email directly, view it on GitHub
<#1219 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPAJEEJC2RX4IHQFYBFZC3USV2YBANCNFSM5HLWMEEA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
We don't want to provide the same solution in multiple plugins. And personally I dislike the idea that we have a plugin for navigation when You can copy the same plugin in the plugins dir without the |
|
Thanks for explaining. I can empathize on both remarks. As the plugin author of a fzf plugin myself that also supports a bit of file navigation and previews, I also felt very wary of tons of requests and PRs to bulk up the search files feature when all I wanted to do was just rely on nnn. I ended up caving in to some requests and now have extra code and features to support and regret it. So should I not have even PRed in gitroot? Anyway, I will stop requesting other plugins like it. |
|
|
|
In that case, great! On the topic of core plugins, I was really confused by how “core plugins” are treated inconsistently and insufficiently. By core plugins I mean plugins such as |
|
Oh and one more thing: symlinked bookmarks are conspicuously missing in the manpages. Happy to try adding it myself once I get the green light from you! |
They are mentioned in the wiki https://github.com/jarun/nnn/wiki/Basic-use-cases#symlinked-bookmarks It was a relatively new feature, so I assume the manpage was forgotten to be updated. |
|
@N-R-K please add a note on symlinked bookmarks in the manpage. @PatrickF1 nnn is very stable and users are fine with how things are. I myself have greater priorities in life than cosmetic changes like moving plugins between folders. I understand you just found nnn and probably got overwhelmed but it's just another basic tool. Feel free to share ideas which really enhance the functionality. |
|
Gotcha. Yeah I did get overwhelmed 😅. Just to give you a data point--though one admittedly probably exceptional--I spent about 12 hours over two days doing intense research mastering nnn. It was rather difficult because of holes in the documentation and the things that don't follow conventions--implicit or stated. I now feel very comfortable with it but am also very aware of its odd design flaws. Thanks for the feedback--going forward I will focus more on significant enhancements. |
|
Oh yes--sorry one more thing that's rather cosmetic but could make a big difference for someone new to nnn. The sort prompt that shows up when you hit t is incredibly confusing even. Would recommend just displaying the whole thing or elaborating in the manpages (right now it's only elaborated on the Wiki). |
|
The following is available in the in-program help (press
The program keys are not documented in the man page.
This is unrelated to |
I think you could just add a symbol. For example, fzf does a good job here. Try opening up fzf --multi (for multi select) and fzf without multi select. They have a one new symbol with --multi to indicate that multiselect is on. |
|
|
Now that you know about |
|
And I don't even think In any case, @PatrickF1 I think you need to stop now. We did come across a few contributors/users earlier who would come up with repeat cosmetic improvement suggestions without doing enough homework. And we had to spend time figuring out the actual problems in implementing those ideas and explaining those to them. It's a bad experience and I don't want to spend my time on those. |
|
I apologize. I was overeager to see nnn improved for all users because I
found the onboarding experience was rough. I hope you can understand that I
wasn’t trying to be annoying but only wanted to offer my design/UX
experience (since I am trained in these areas). And I never expected my
ideas to be investigated immediately, only as food for thought for
potential future roadmap items.
I should have caught from the tone of your writing that you guys found my
suggestions unwelcome and stopped earlier. In any case, thank you for
listening and creating nnn.
…On Thu, Dec 30, 2021 at 4:50 PM Arun ***@***.***> wrote:
And I don't even think v and ^ can be replaced by a percentage. How do
you know at a glance whether there are more elements if you scroll up or
not? And a percentage is an approximation. In a directory having 10000
files, several last entries would show 100%.
In any case, @PatrickF1 <https://github.com/PatrickF1> I think you need
to stop now. We did come across a few contributors/users earlier who would
come up with repeat cosmetic improvement suggestions without doing enough
homework. And we had to spend time figuring out the actual problems in
implementing those ideas and explaining those to them. It's a bad
experience and I don't want to spend my time on those. nnn can be
modified very easily. Feel free to make changes in your local copy and use
them.
—
Reply to this email directly, view it on GitHub
<#1219 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPAJEC5TMNIVHCL2FJTNLLUTT43RANCNFSM5HLWMEEA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
No problem! Thanks for your understanding. |
|
Since the topic of UX/UI came up, I'd like to add that there are many terminal file mangers which focus quite heavily on cosmetics and looks. Many of which I've installed, and then uninstalled within 2 minutes after seeing that there's a noticeable delay when doing basic tasks like scrolling, going in/out of a directory etc. In attempt to make their UI better, they've ended up making it unuseable for people like me who are sensitive towards latency and responsiveness. When making UI decisions one has to keep in mind, that in the unix world worse is better. |
|
Yo just leaving this here after altering Preview-tui to work with Windows Terminal with WSL, as I've avoided Xserver for various reasons. I'm pretty new to Bash scripting so do with it what you will I didn't add much, just really liked the project and wanted features to work with what I had. https://gist.github.com/WanderLanz/fae8b8e09746d611f384dc40d1bd41c9 Obviously haven't used github site alot :P as well. |
|
@WanderLanz thank you! @luukvbaal @N-R-K can any of you adapt this to the plugin please? |
|
@WanderLanz were you dissatisfied with the option of running Not sure it's worth adding this just to avoid the |
|
I myself don't use tmux on wsl. A semi-native solution helps. |
|
There's no need "use" tmux. Just installing it is enough to make preview-tui work. Anyhow the gist doesn't work at all for me, it opens a 2 new wt instances and errors out. |
|
This option is required to make it work |
That's more like it.
Yes nnn needs to run inside tmux. I don't "use" tmux myself either but I use an alias for nnn like
The tmux solution feels just as, if not more, native in my opinion. |
|
Oh, by default you need to follow https://github.com/jarun/nnn/wiki/Troubleshooting#tmux-configuration . You can still use the WT workaroud if you aren't going to install tmux if you want, just be aware that I'm running it first though Powershell (powershell.exe on WSL, as C:\Windows and System32 paths are added to your $PATH) then WT to make it work. Along with some few caveats: WT itself doesn't add "native" support itself for these kind of things, and for some reason simply running C:\path\to\wt.exe doesn't work with straight from WSL so I can only seem to get it working through powershell.exe subterminal Because it's running through powershell, any ";" in the command has been picked up first by powershell rather than bash, so '&&' has been used. The PATH and PAGER vars cannot be passed along in any way that I've tried due to spaces, so I just remove PAGER and source $HOME/.profile instead, if you know a way to fix that please share. Other than that, I really love the work you guys are doing here! The WSL community seems to be growing pretty rapidly these days with WSL2 and WSLg, I'd recommend Chris-Titus Windows Debloater script or another debloater to free up some room for things like ghci which has been pretty instensive for me on WSL lol. Although I'm a gamer first, so I might be more picky about these things : P . |
|
@WanderLanz if you're compiling from source then you can use the git status patch to get some git integration. |
|
@N-R-K Thanks! I was wondering if there were other cool features like that. |
|
@WanderLanz "Cooking" is a list of features/changes currently present on |
|
@N-R-K Thanks for letting me know, I'm not the brightest in the crowd : P . |
|
If you still wanted that preview-tui for use straight through Windows Terminal, although I now know you can just run it through tmux, I updated it to import the PATH and PAGER correctly. |
|
Thanks, I made the PR. Although It does require less setup I guess, so there's that. |
|
I mean, there is a "wt.exe" wsl command to (/mnt/c/Users/<User>/AppData/Local/Microsoft/WindowsApps/wt.exe) through the wsl PATH preloading, but I can't figure out how to pass sub-commands or flags to it through bash. As I'm not a very well-versed person in the wt innerworkings or how wsl passes flags to .exe commands, does anyone have any idea if there is a way to make it work? |
|
As in https://docs.microsoft.com/en-us/windows/terminal/command-line-arguments?tabs=linux |
|
let me whip it up real quick to see if it's noticeable at all... |
|
sorry about the spam btw, do you want me to move under #1289 for now ? I'm well aware I'm being annoying and you guys are probably doing better things with your time than I am. |
|
You're fine. If you have further additions the discussion is best continued in #1289 yeah. |
Rolled from #1193.
Cooking
-i) enabledgitrootto jump to git root directory from a subtreepreview-tui- fix gif conversion and whitespace namepreview-tui- add support for windows terminal splitnuke- add support forimvwhen named imvSEDO_NOSORTto load directories unsorted on entryUp for grabs
None open at the time.
For anything else please discuss in this thread.
Contribution guideline.
The text was updated successfully, but these errors were encountered: