feature: define variadic function parser #34
Conversation
The define syntax should be able to parse both lambda's and variable definitions.
|
Thanks! This looks good to me. The PR includes 6 commits, 2 of which are already on master and one is a merge. Do you mind rebasing your branch on top of current master? That should give you the same result with just the 3 new commits you added for this change. |
| let (i, _) = tuple((open, tag("define"), space1))(i)?; | ||
| let (i, mut params) = delimited(open, identifiers, tag("."))(i)?; | ||
| let (i, rest_param) = delimited(space0, identifier, close)(i)?; | ||
| let (i, body) = delimited(space0, many1(terminated(expression, space0)), space0)(i)?; |
There was a problem hiding this comment.
You might need space1 instead of space0 in let (i, rest_param) = delimited(space0, identifier, close)(i)?; to make sure that there is atleast one space after the ..
I havent tested this yet, but could you try what happens for (define (add x y .args) (reduce + 0 args)) please?
There was a problem hiding this comment.
The space is necessary, otherwise .args becomes one identifier instead of what we want here.
Right. Yes! |
This change was done to make sure that we have one space delimiter for sure - as mentioned in the review
|
I'm closing this and will make a new PR after fixing those commits from my |
|
@kolharsam You could force push the rebased branch instead of reopening a new PR, since that keeps all the discussion in one place. Its not an issue in this case, but its a useful thing to know since its really not uncommon having to clean up a branch several times before getting it merged in a larger project. |
Adds mainly the parser for the variadic function some of the other commits were already merged, I just forgot to merge your master prior to making these updates.