Project.toml #4
Open
Project.toml #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Some general improvements to the getting started guide - Includes a shutdown handler (best practice) - Uses a modern, async-aware test runner (Jest) - Aligns on the change to use port 5006 (+3 squashed commits) * Update README.md Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com> * Update package.json Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com> * Drop `version` + add `private: true` --------- Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
* Updated with fir-related content and links * Remove Deploy to Heroku button * Apply suggestions from code review --------- Co-authored-by: Richard Schneeman <richard.schneeman+no-recruiters@gmail.com>
* Use shared alias instead of link Conforming to existing style with some noted reservations heroku/nodejs-getting-started#348 (comment). * Fix fir tutorial link * Fix .NET capitalization
* Add logging output from the server Currently nothing from the server logs when `/` is rendered, the only logs are from the router: ``` 2024-12-05T22:12:31.218143+00:00 heroku[router]: at=info method=GET path="/" host=sheltered-eyrie-60144-d97e98d69373.herokuapp.com request_id=f2739cdb-62b2-464a-b2fe-2723ca64ff00 fwd="13.110.54.11" dyno=web.1 connect=0ms service=20ms status=304 bytes=152 protocol=https 2024-12-05T22:12:31.392858+00:00 heroku[router]: at=info method=GET path="/stylesheets/main.css" host=sheltered-eyrie-60144-d97e98d69373.herokuapp.com request_id=7c197cb2-09d7-43d0-ad43-59c8736291b1 fwd="13.110.54.11" dyno=web.1 connect=0ms service=8ms status=200 bytes=908 protocol=https 2024-12-05T22:12:31.506876+00:00 heroku[router]: at=info method=GET path="/lang-logo.png" host=sheltered-eyrie-60144-d97e98d69373.herokuapp.com request_id=1765623e-0a0a-48ce-9f4f-df7eff8bc381 fwd="13.110.54.11" dyno=web.1 connect=0ms service=11ms status=200 bytes=2567 protocol=https ``` This is what server logs look after this change: ``` 2024-12-05T22:11:15.351801+00:00 heroku[router]: at=info method=GET path="/stylesheets/main.css" host=sheltered-eyrie-60144-d97e98d69373.herokuapp.com request_id=1bd60918-0c11-4c08-848a-d6bfb63ba7ae fwd="13.110.54.11" dyno=web.1 connect=0ms service=1ms status=304 bytes=237 protocol=https 2024-12-05T22:11:15.247601+00:00 heroku[router]: at=info method=GET path="/" host=sheltered-eyrie-60144-d97e98d69373.herokuapp.com request_id=e92141bc-eb31-4722-accb-5c9c243a4e00 fwd="13.110.54.11" dyno=web.1 connect=0ms service=2ms status=304 bytes=152 protocol=https 2024-12-05T22:11:15.246313+00:00 app[web.1]: Rendering `pages/index` 2024-12-05T22:11:15.246329+00:00 app[web.1]: 2024-12-05T22:11:15.246330+00:00 app[web.1]: Use `console.log()` on the server to send text to stdout. 2024-12-05T22:11:15.246349+00:00 app[web.1]: That log text is viewable via the `heroku logs` command or via a logging add-on. 2024-12-05T22:11:15.246349+00:00 app[web.1]: 2024-12-05T22:11:15.353613+00:00 heroku[router]: at=info method=GET path="/lang-logo.png" host=sheltered-eyrie-60144-d97e98d69373.herokuapp.com request_id=4229139a-67a0-4dbe-b568-561e11768143 fwd="13.110.54.11" dyno=web.1 connect=0ms service=1ms status=304 bytes=237 protocol=https ``` This accomplishes: - Showing how router and web logs will differ. - Explaining via text in the logs how they can log (`console.log()`) as opposed to some people expecting to write to a log file on disk. - Explaining how to view those logs (the `heroku logs` command) - Hinting that a logging add-on might be a good idea * Simplify log message * Simplify log message --------- Co-authored-by: Colin Casey <casey.colin@gmail.com>
jason-salesforce
temporarily deployed
to
bleh-project-toml-6omxcrmpxvzp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.