This repository was archived by the owner on Dec 29, 2018. It is now read-only.
Update to Swift 1.2 #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- countElements() renamed to count()
String.append() doesn't like emoji for some reason, seems like a bug
|
As to the Travis CI build failure, I believe they have yet to update to Xcode 6.3. |
|
Thanks @beltex! I started looking into this myself, but I didn't have time to track down the emoji failure. (I don't care specifically about emoji options, but they are a good stand-in for making sure unicode characters will work in option flags). I don't expect Travis CI to add Xcode 6.3 until it's out of beta, but the tests pass cleanly here too 👍 |
|
np! :) Indeed, they made a nice catch! |
|
The |
|
Thanks for the heads up, @beltex 👍 |
|
np! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jatoben! Updated to Swift 1.2, all tests pass. Here are the changes:
countElements()was renamed tocount()String.append()doesn't like emoji for some reason now, seems like a bug. So I added a small workaround for that astestEmojiOptionswas failing