Added SetLocalTime definition to 'com.sun.jna.platform.win32.Kernel32' #432
Conversation
|
All ready... |
|
Just missing CHANGES! :) |
| * privileges and it may be too much to ask to have them just for running | ||
| * this JNA API test... | ||
| */ | ||
| if (hr == WinError.ERROR_PRIVILEGE_NOT_HELD) { |
There was a problem hiding this comment.
May I suggest using assumeTrue, see https://github.com/twall/jna/blob/master/contrib/platform/test/com/sun/jna/platform/win32/Dxva2Test.java#L62 for an example. It will be a lot cleaner and much less code.
There was a problem hiding this comment.
Not the same thing - if the error code is ERROR_PRIVILEGE_NOT_HELD I don't want the test to fail, but for all other error codes I want the assertion failure. Therefore, using Assume.assumeTrue("SetSystemTime", INSTANCE.SetSystemTime(...)) would be incorrect since it would not make sure that the failure is due to the privilege issue and nothing else.
|
I have changed it and used |
|
Merging, thanks. |
Added SetLocalTime definition to 'com.sun.jna.platform.win32.Kernel32'
Motivation: New is always better. Modification: Upgrade to the latest JUnit 5 version. Result: Tests run with the latest JUnit version.
Added missing 'SetLocalTime' + updated the tests to take into account user privileges (stay tuned for the CHANGES.md commit...)