Skip to content

Conversation

terhesb
Copy link
Contributor

@terhesb terhesb commented Apr 18, 2019

Just a little fix in the tests to make it 100% good.

@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #202 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #202   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity     1117   1117           
=======================================
  Files             8      8           
  Lines          3414   3414           
  Branches        657    657           
=======================================
  Hits           3414   3414

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c55eae6...b2caa4b. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b2caa4b on terhesb:master into c55eae6 on javadev:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b2caa4b on terhesb:master into c55eae6 on javadev:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b2caa4b on terhesb:master into c55eae6 on javadev:master.

Copy link
Owner

@javadev javadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
There are no changes in coverage report:

@@           Coverage Diff           @@
##             master   #202   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity     1117   1117           
=======================================
  Files             8      8           
  Lines          3414   3414           
  Branches        657    657           
=======================================
  Hits           3414   3414

@terhesb
Copy link
Contributor Author

terhesb commented Apr 18, 2019

Hi, yes. But at least all the tests are good. May I include this change alongside another change?

Copy link
Owner

@javadev javadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javadev javadev merged commit 8c3eedd into javadev:master Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants