Skip to content

Add U.first(iterable, pred, n) method and fix other U.first() methods. #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2019

Conversation

terhesb
Copy link
Contributor

@terhesb terhesb commented Apr 19, 2019

In this change I implemented a new first method, which return a list with the first n elements that satisty the predicate.
I also fixed a bug in the U.java file. At the 1138. row the Math.min(n, list.size()) call was missing.

@codecov
Copy link

codecov bot commented Apr 19, 2019

Codecov Report

Merging #203 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #203   +/-   ##
=======================================
  Coverage       100%   100%           
- Complexity     1117   1119    +2     
=======================================
  Files             8      8           
  Lines          3414   3419    +5     
  Branches        657    657           
=======================================
+ Hits           3414   3419    +5
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/github/underscore/U.java 100% <100%> (ø) 601 <7> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c3eedd...3cfa609. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3cfa609 on terhesb:first into 8c3eedd on javadev:master.

Copy link
Owner

@javadev javadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javadev javadev merged commit 0aa274c into javadev:master Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants