New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a TomEE 2.0 build profile #261

Closed
johnament opened this Issue Oct 5, 2014 · 22 comments

Comments

Projects
None yet
6 participants
@johnament
Contributor

johnament commented Oct 5, 2014

Let's add a TomEE 2.0 build profile, so that we can start testing out the new version of TomEE in web profile.

Note that we'll need to use TomEE plus for now. I think at some point we need to add support for different profiles, and perhaps different test suites per container based on what should work.

@arun-gupta

This comment has been minimized.

Show comment
Hide comment
@arun-gupta

arun-gupta Oct 5, 2014

Contributor

How much Java EE 7 is there in TomEE 2.0 ?

Contributor

arun-gupta commented Oct 5, 2014

How much Java EE 7 is there in TomEE 2.0 ?

@johnament

This comment has been minimized.

Show comment
Hide comment
@johnament

johnament Oct 5, 2014

Contributor

It's by no means final, but looking at the contents I see:

  • JBatch (BatchEE is a fork of the RI)
  • JAX-RS
  • CDI
  • JAX-WS
  • JSON
  • EJB

There's still some gaps around JMS and JPA

Contributor

johnament commented Oct 5, 2014

It's by no means final, but looking at the contents I see:

  • JBatch (BatchEE is a fork of the RI)
  • JAX-RS
  • CDI
  • JAX-WS
  • JSON
  • EJB

There's still some gaps around JMS and JPA

@arjantijms

This comment has been minimized.

Show comment
Hide comment
@arjantijms

arjantijms Oct 5, 2014

Contributor

There's btw also quite a bunch of Java EE 7 in the latest Liberty releases (see https://developer.ibm.com/wasdev/2014/09/12/announcing-liberty-profile-september-beta)

Quickly glancing over the release data it seems to have;

  • JBatch 1.0
  • Concurrent Utils 1.0
  • JAX-RS 2.0
  • JMS 2.0
  • JPA 2.1
  • BeanValidation 1.1
  • JSON-P 1.0
  • EJB 3.2 Lite
  • Servlet 3.1
Contributor

arjantijms commented Oct 5, 2014

There's btw also quite a bunch of Java EE 7 in the latest Liberty releases (see https://developer.ibm.com/wasdev/2014/09/12/announcing-liberty-profile-september-beta)

Quickly glancing over the release data it seems to have;

  • JBatch 1.0
  • Concurrent Utils 1.0
  • JAX-RS 2.0
  • JMS 2.0
  • JPA 2.1
  • BeanValidation 1.1
  • JSON-P 1.0
  • EJB 3.2 Lite
  • Servlet 3.1
@arun-gupta

This comment has been minimized.

Show comment
Hide comment
@arun-gupta

arun-gupta Oct 5, 2014

Contributor

Add profiles for both of them ?

I asked one of the IBM guys (@notatibm) to add a profile for Liberty but he seems to be busy. Moreover they were not able to parse a Servlet 3.1 DD so most of their tests would fail anyway.

Contributor

arun-gupta commented Oct 5, 2014

Add profiles for both of them ?

I asked one of the IBM guys (@notatibm) to add a profile for Liberty but he seems to be busy. Moreover they were not able to parse a Servlet 3.1 DD so most of their tests would fail anyway.

@arjantijms

This comment has been minimized.

Show comment
Hide comment
@arjantijms

arjantijms Oct 5, 2014

Contributor

I haven't tested a Servlet 3.1 web.xml yet, but it's clearly early days for Liberty Java EE 7 (just as it's for TomEE 2.0 I guess).

Then again, one way of testing is that in the beginning indeed everything fails and that over time the pass rate slowly but steadily increases ;)

Contributor

arjantijms commented Oct 5, 2014

I haven't tested a Servlet 3.1 web.xml yet, but it's clearly early days for Liberty Java EE 7 (just as it's for TomEE 2.0 I guess).

Then again, one way of testing is that in the beginning indeed everything fails and that over time the pass rate slowly but steadily increases ;)

@radcortez

This comment has been minimized.

Show comment
Hide comment
@radcortez

radcortez Oct 5, 2014

Contributor

I see no problem in adding additional Applications Servers, but shouldn't we wait until we have an official final release for Java EE 7?

Contributor

radcortez commented Oct 5, 2014

I see no problem in adding additional Applications Servers, but shouldn't we wait until we have an official final release for Java EE 7?

@johnament

This comment has been minimized.

Show comment
Hide comment
@johnament

johnament Oct 5, 2014

Contributor

What do you mean, java we 7 is final. Or that we should wait for the servers to go final before seeing if the examples work?

Contributor

johnament commented Oct 5, 2014

What do you mean, java we 7 is final. Or that we should wait for the servers to go final before seeing if the examples work?

@arun-gupta

This comment has been minimized.

Show comment
Hide comment
@arun-gupta

arun-gupta Oct 6, 2014

Contributor

I'd love to see upcoming server profiles being added and see steady progress. Seems like my request will got lost in IBM. Who wants to own Liberty Profile ?

@arjantijms seems like you will add TomEE profile ?

Contributor

arun-gupta commented Oct 6, 2014

I'd love to see upcoming server profiles being added and see steady progress. Seems like my request will got lost in IBM. Who wants to own Liberty Profile ?

@arjantijms seems like you will add TomEE profile ?

@johnament

This comment has been minimized.

Show comment
Hide comment
@johnament

johnament Oct 6, 2014

Contributor

I added a new ticket for liberty - #263

Contributor

johnament commented Oct 6, 2014

I added a new ticket for liberty - #263

@radcortez

This comment has been minimized.

Show comment
Hide comment
@radcortez

radcortez Oct 6, 2014

Contributor

@johnament I meant wait for an official Java EE 7 release for each of the servers. We can work on it, but I just fear that lot of things may fail.

Contributor

radcortez commented Oct 6, 2014

@johnament I meant wait for an official Java EE 7 release for each of the servers. We can work on it, but I just fear that lot of things may fail.

@aslakknutsen

This comment has been minimized.

Show comment
Hide comment
@aslakknutsen

aslakknutsen Oct 6, 2014

Member

I see no problem with adding non finished profiles. One of the original reasons I wanted Arquillian tests in JavaEE Samples was to see what works where, spec defined or not.

TomEE should be no problem as that is all Open Source. Not 100% sure about the Liberty Profile, but if it follows the same Developer License as WAS you're not allowed to run it on a build server. (e.g. we could add the profile, but can't automate the test runs)

Member

aslakknutsen commented Oct 6, 2014

I see no problem with adding non finished profiles. One of the original reasons I wanted Arquillian tests in JavaEE Samples was to see what works where, spec defined or not.

TomEE should be no problem as that is all Open Source. Not 100% sure about the Liberty Profile, but if it follows the same Developer License as WAS you're not allowed to run it on a build server. (e.g. we could add the profile, but can't automate the test runs)

@NottyCode

This comment has been minimized.

Show comment
Hide comment
@NottyCode

NottyCode Oct 6, 2014

There are a few comments here about the Liberty profile. Since #263 has been raised since most of them I have placed my thoughts regarding the Liberty profile as a comment on that issue rather than risk further diverting this issue from the original intent.

NottyCode commented Oct 6, 2014

There are a few comments here about the Liberty profile. Since #263 has been raised since most of them I have placed my thoughts regarding the Liberty profile as a comment on that issue rather than risk further diverting this issue from the original intent.

@radcortez

This comment has been minimized.

Show comment
Hide comment
@radcortez

radcortez Oct 29, 2014

Contributor

I'm working in adding TomEE to the samples.

Contributor

radcortez commented Oct 29, 2014

I'm working in adding TomEE to the samples.

@radcortez

This comment has been minimized.

Show comment
Hide comment
@radcortez

radcortez Oct 31, 2014

Contributor

A few preliminary results:

batch - No Implementation Provided
cdi - Failing a few tests. Most are related with the absence of a beans.xml
concurrency - Failing a few tests. DefaultManagedExecutorService not binded to JNDI comp/DefaultManagedExecutorService
ejb - Failure in TimerService
el - Missing Lambda Support
interceptor - OK
jacc - No Implementation Provided
jaspic - No Implementation Provided
javamail - OK
jaxrs - Failing a few tests. Related with other specs, like json-p and jpa
jaxws - OK
jca - OK
jms - Test Failures
jpa - No support for JPA 2.1 yet
jsf - A few failures
json-p - OK
jta - Failing a few tests. Related with other specs, like jpa
servlet - Failing a few tests. Related with security stuff
validation - Test Failures
websocket - OK

Contributor

radcortez commented Oct 31, 2014

A few preliminary results:

batch - No Implementation Provided
cdi - Failing a few tests. Most are related with the absence of a beans.xml
concurrency - Failing a few tests. DefaultManagedExecutorService not binded to JNDI comp/DefaultManagedExecutorService
ejb - Failure in TimerService
el - Missing Lambda Support
interceptor - OK
jacc - No Implementation Provided
jaspic - No Implementation Provided
javamail - OK
jaxrs - Failing a few tests. Related with other specs, like json-p and jpa
jaxws - OK
jca - OK
jms - Test Failures
jpa - No support for JPA 2.1 yet
jsf - A few failures
json-p - OK
jta - Failing a few tests. Related with other specs, like jpa
servlet - Failing a few tests. Related with security stuff
validation - Test Failures
websocket - OK

@arjantijms

This comment has been minimized.

Show comment
Hide comment
@arjantijms

arjantijms Oct 31, 2014

Contributor

Hi,

On Fri, Oct 31, 2014 at 4:52 PM, Roberto Cortez notifications@github.com
wrote:

A few preliminary results:

[...]
jacc - Tests Failures
jaspic - Tests Failures

This is expected as TomEE implements neither. It's still on my TODO to
provide a JASPIC implementation for TomEE. The tests in this project were
actually partially intended to test that implementation against ;)

Kind regards,
Arjan

Contributor

arjantijms commented Oct 31, 2014

Hi,

On Fri, Oct 31, 2014 at 4:52 PM, Roberto Cortez notifications@github.com
wrote:

A few preliminary results:

[...]
jacc - Tests Failures
jaspic - Tests Failures

This is expected as TomEE implements neither. It's still on my TODO to
provide a JASPIC implementation for TomEE. The tests in this project were
actually partially intended to test that implementation against ;)

Kind regards,
Arjan

@arun-gupta

This comment has been minimized.

Show comment
Hide comment
@arun-gupta

arun-gupta Oct 31, 2014

Contributor

This is great feedback @radcortez. Have you shared with David Blevins ?

Contributor

arun-gupta commented Oct 31, 2014

This is great feedback @radcortez. Have you shared with David Blevins ?

@radcortez

This comment has been minimized.

Show comment
Hide comment
@radcortez

radcortez Oct 31, 2014

Contributor

Not yet @arun-gupta, but I'll do it. I was just finalizing some stuff. I'll probably email him today.

Contributor

radcortez commented Oct 31, 2014

Not yet @arun-gupta, but I'll do it. I was just finalizing some stuff. I'll probably email him today.

@radcortez

This comment has been minimized.

Show comment
Hide comment
@radcortez

radcortez Oct 31, 2014

Contributor

@arjantijms yes, I suspected that, but I was not familiar with what TomEE had on that department. Thanks for clearing that out :)

Contributor

radcortez commented Oct 31, 2014

@arjantijms yes, I suspected that, but I was not familiar with what TomEE had on that department. Thanks for clearing that out :)

@radcortez radcortez closed this in 73177b0 Nov 2, 2014

@radcortez

This comment has been minimized.

Show comment
Hide comment
@radcortez

radcortez Nov 2, 2014

Contributor

Btw, TomEE 2.0 maven artifacts are not available in any of the public repos, so anyone that wants to run the samples with TomEE will need to clone their repo and build it locally: https://github.com/apache/tomee

Contributor

radcortez commented Nov 2, 2014

Btw, TomEE 2.0 maven artifacts are not available in any of the public repos, so anyone that wants to run the samples with TomEE will need to clone their repo and build it locally: https://github.com/apache/tomee

@arjantijms

This comment has been minimized.

Show comment
Hide comment
@arjantijms

arjantijms Nov 2, 2014

Contributor

@radcortez you're welcome ;)

Btw, anyone knows what the roadmap is for TomEE 2.0? There were some Tweets and the odd discussion here and there, but nothing really definitive (at least nothing that I could find after some quick Googling).

Contributor

arjantijms commented Nov 2, 2014

@radcortez you're welcome ;)

Btw, anyone knows what the roadmap is for TomEE 2.0? There were some Tweets and the odd discussion here and there, but nothing really definitive (at least nothing that I could find after some quick Googling).

@radcortez

This comment has been minimized.

Show comment
Hide comment
Contributor

radcortez commented Nov 3, 2014

@arjantijms

This comment has been minimized.

Show comment
Hide comment
@arjantijms

arjantijms Nov 4, 2014

Contributor

@arjantijms https://github.com/arjantijms did you found this email
thread?

Saw it before, but just noticed there are some new replies. Thanks!

Contributor

arjantijms commented Nov 4, 2014

@arjantijms https://github.com/arjantijms did you found this email
thread?

Saw it before, but just noticed there are some new replies. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment