JPA test for aggregate functions in select clause #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjantijms
added a commit
that referenced
this pull request
Nov 25, 2015
JPA test for aggregate functions in select clause
|
Just wondering what is the point of the PR if you merge it on your own? :) |
|
Well, to be able to develop in a fork and test it first on different platforms, without disturbing the main project yet. Then when the new test seems reasonably okay, I do the PR, so it kicks of the CI job. That CI job ensures that everything compiles and I didn't accidentally dependent on something that's on any of my test platforms. Finally, I don't merge right away after the CI job finishes, but let the PR sit there for some 12 hours or so, so people can provide feedback if needed. If there's no feedback after that time I merge it in. So, multiple reasons ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on GlassFish, WildFly, Liberty and WebLogic
Fails on GlassFish, WildFly and Liberty for various reasons:
Tested Liberty with alternative version using Liberty proprietary data source and test passed then.