-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jgltf-browser preview release 4 is not support glTF 1.1? #10
Comments
Yes, I also noticed this during my tests yesterday, and I fixed it in a728240 This problem was only in the validator. The viewer could actually display it, but the browser does a check like
(pseudocode). I have to think about how to tackle this in general. The validator is in a very early state, and was only intended to detect the errors that would cause a crash of the browser. It might require further updates for glTF 1.1, and in any case, it will have to be extended to perform a more systematic validation, like the official https://github.com/KhronosGroup/glTF-Validator I will try to create a new release ASAP. I'll not be able to do this before Monday, but maybe I can start extending the validator before the weekend. Maybe even add an option to ignore errors from the validator, even if this means that the viewer might crash for a certain model. The error handling for glTF in general is something that is not completely settled yet (related: KhronosGroup/glTF#695 (comment) ) |
I am not in a hurry, I would like to wait for a new release next year :) When reading SimpleTexture.gltf with GLBoost, the display was inverted upside down. I tried to confirm with JglTF whether it was correct. |
If the texture seems to be flipped vertically, then this is the same as in JglTF. For the screenshot, I rotated the camera (around the x-axis) to show the other side of the object. I cannot say for sure whether this is "correct" or not. But think that it is "correct". The problem of vertically flipped textures is omnipresent in computer graphics (and it's really annoying). All the APIs and file formats have different specifications and conventions, and in some cases, additional ambiguities are introduced by the programming language or the image loader library. For WebGL, there is even a dedicated setting Off-topic: I already mentioned it elsewhere, but your loader test is awesome, and really useful (particularly for me: I'm not so familiar with JavaScript, and setting up all these libraries for a basic test would take me many hours...) But I'm surprised that so many loaders seem to have problems with loading these "mini" test models. For example, the "SimpleMaterial" (embedded) one:
It seems like someone is going to open quite a few issue reports in the next days... |
I have created a new (still: preview) release at https://github.com/javagl/JglTF/releases/tag/v0.0.0-alpha05 |
Thank you very much. I will use it. |
@cx20 The point about the texture being displayed upside down that you mentioned in #10 (comment) has been "fixed". Actually, there was nothing wrong. But it was considered to be potentially confusing in CesiumGS/cesium#4808 (comment) : Originally, the texture coordinates had been a "unit square"
And now ( javagl/gltfTutorialModels@3a2dbf4 ) they are a vertically flipped unit square:
I have also updated the texture image to reflect this, and emphasized this in the README at https://github.com/javagl/gltfTutorialModels/tree/master/SimpleTexture . Maybe it will help to reduce the confusion. Of course, this is not a reliable analysis, but searching GitHub for issues involving Note: This is just an information. The models here are still in the 1.1 state, and will be updated to 2.0 and added to the official Khronos repo when the dust around 2.0 has settled. |
It seems that it becomes an error when reading the following sample.
https://cdn.rawgit.com/javagl/gltfTutorialModels/master/SimpleTexture/glTF/SimpleTexture.gltf
I want latest gltf-browser jar...
The text was updated successfully, but these errors were encountered: