Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java.net.URI.toURI broken #457

Closed
cyrille-artho opened this issue May 31, 2024 · 0 comments
Closed

java.net.URI.toURI broken #457

cyrille-artho opened this issue May 31, 2024 · 0 comments

Comments

@cyrille-artho
Copy link
Member

The model class implements toURI, but this function was not tested with a unit test. We therefore need a unit test and then a fix.

  1. Create a unit test that constructs a simple URI from a File with a String that has the right URI syntax.

  2. Look into ways to obtain a working URI by fixing a dependency in the JPF model classes, most likely by adding setJavaNetURIAccess, which is probably going to resemble setJavaNetURLAccess.

Also look into the class description JavaDoc of src/classes/modules/java.base/jdk/internal/misc/SharedSecrets, which still refers to Java 1.5/Java 6 and is therefore seriously outdated.

If the model class for SharedSecrets can indeed be removed, we want a careful review of its use of Unsafe and whether removal might cause problems later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant