[Improvement] Disable console output improvement

[da411d]

Today disableConsoleOutput looks like this:

const func = function () {};
const that = GLOBAL;
if (!that.console) {
  that.console = (function (func){
    const c = {};
    
    c.log = func;
    c.warn = func;
    c.debug = func;
    c.info = func;
    c.error = func;
    c.exception = func;
    c.table = func;
    c.trace = func;
    
    return c;
  })(func);
} else {
  that.console.log = func;
  that.console.warn = func;
  that.console.debug = func;
  that.console.info = func;
  that.console.error = func;
  that.console.exception = func;
  that.console.table = func;
  that.console.trace = func;
}

Yes, it just works, but if we type console.log in console, we see empty function:

My improvement idea is to override toString method to make it look more realistic:

For this you need add just 3 lines of code to current template:

var toString = () => "function () { [native code] }";
toString.toString = toString;
func.toString = toString;

Now it looks more realistic, but still not perfect. We can bind original toStinrg method to new empty function:

Now console.log looks like native function.

const cons = window.console;
for(let key in cons){
  const originalFunction = cons[key];
  if(typeof originalFunction !== "function") continue;
  const func = function () {};
  func.toString = originalFunction.toString.bind(originalFunction);
  cons[key] = func;
};

I'm not sure this improvement matters, or just "works - don't touch"

UPD: seems it don't work for firefox, just Chromium, but Chromium is used by more users

[sanex3339]

For me, it works fine in FF 70 and 77

[da411d]

[sanex3339]

Hi. Take a look at the PR. #692

[da411d]

There can be problems with Content-Security-Policy, because for browser Function() is equal to eval.

[da411d]

Also console has more than 20 methods, but you override only 7 of them.
I think you have a reason for this, I would like to hear your opinion)

[sanex3339]

There can be problems with Content-Security-Policy, because for browser Function() is equal to eval.

Oh, that's true

[sanex3339]

Also console has more than 20 methods, but you override only 7 of them.
I think you have a reason for this, I would like to hear your opinion)

I have to cover case when console object does not exist.
javascript-obfuscator/webpack-obfuscator#13

As a result, I need to describe the array with the list of console methods that I want to replace.
To make this list smaller I describe only main methods of console object

[sanex3339]

Will use

const func = {callControllerFunctionName}.constructor.prototype;

[da411d]

Will use constructor.prototype

[sanex3339]

 for (let index = 0; index < methods.length; index++){
            const func = callControllerFunctionName.constructor.prototype.bind(callControllerFunctionName);
            const methodName = methods[index];
            const originalFunction = consoleObject[methodName] || func;

            func.toString = originalFunction.toString.bind(originalFunction);
            consoleObject[methodName] = func;
        }

[sanex3339]

Hmm, need to check if this can break anything outside this template. Looks like no, bind creates a new function

[da411d]

That is a bit strange, but it's not critical

[sanex3339]

Yeah, but I think it's not critical.