Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long polling #354

Merged
merged 11 commits into from
Aug 27, 2020
Merged

Long polling #354

merged 11 commits into from
Aug 27, 2020

Conversation

homero304
Copy link
Contributor

Hi. Please review my PR.
question. How can i see the svg image in the article ?
I have the following error: /long-polling.svg: Could not execute GraphicsMagick/ImageMagick: identify "-ping" "-format" "{"width":%w,"height":%h}" "/long-polling.svg
I tried to install ImageMagick7 -- https://linuxconfig.org/how-to-install-imagemagick-7-on-ubuntu-18-04-linux
but ran into trouble when i tried to run the server again. It was complaining that it could not create a symbolic link for ImageMagick7++...la

Thanks
Regards,
Homero Marin

@joaquinelio
Copy link
Member

Sobre img sobre server, ni idea. Igual no hace falta, Eze los tradujo todos, si no modificas el link funcionará.
Acá mismo lo podes probar "file changes" y en el menu "...", "view file"

¡Eh!

@iliakan iliakan mentioned this pull request 12 minutes ago Spanish Translation Progress #17

¡Fui yo quien lo agregó hace 12 minutos! Este bot más boleado cada día.

Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Algunas cosas...

que sugerí tambien cambiar en inglés
jeje Apuesto que lo rechaza pero que lo rescribe uno que sí sabe inglés.

5-network/10-long-polling/article.md Outdated Show resolved Hide resolved
5-network/10-long-polling/article.md Outdated Show resolved Hide resolved
5-network/10-long-polling/article.md Outdated Show resolved Hide resolved
5-network/10-long-polling/article.md Outdated Show resolved Hide resolved
5-network/10-long-polling/article.md Outdated Show resolved Hide resolved
5-network/10-long-polling/article.md Outdated Show resolved Hide resolved
5-network/10-long-polling/longpoll.view/browser.js Outdated Show resolved Hide resolved
5-network/10-long-polling/longpoll.view/server.js Outdated Show resolved Hide resolved
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

omero329 and others added 9 commits August 22, 2020 20:48
acentuacion de conjugacion estar en subjuntivo

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
cuesstión de percepcion...

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
conexiones, procesos y memoria consumida

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
lenguajes, problema de implementacion no del lenguaje en si. algunos lenguajes son mas amigables que otros

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
pasado de expirar

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
a -> para

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
periodico

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@homero304
Copy link
Contributor Author

/done

Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@vplentinax vplentinax merged commit fa5cee7 into javascript-tutorial:master Aug 27, 2020
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants