Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser default actions #378

Merged
merged 13 commits into from
Sep 15, 2020
Merged

Browser default actions #378

merged 13 commits into from
Sep 15, 2020

Conversation

homero304
Copy link
Contributor

please review my PR

joaquinelio
joaquinelio requested changes Sep 11, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creo que no hay errores y todas son sugerencias de estilo, aplicala s o cambialas si queres

2-ui/2-events/04-default-browser-action/article.md Outdated Show resolved Hide resolved
2-ui/2-events/04-default-browser-action/article.md Outdated Show resolved Hide resolved
2-ui/2-events/04-default-browser-action/article.md Outdated Show resolved Hide resolved
2-ui/2-events/04-default-browser-action/1-why-return-false-fails/solution.md Outdated Show resolved Hide resolved
2-ui/2-events/04-default-browser-action/2-catch-link-navigation/solution.md Outdated Show resolved Hide resolved
2-ui/2-events/04-default-browser-action/3-image-gallery/source.view/index.html Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@joaquinelio joaquinelio mentioned this pull request Sep 11, 2020
Open
omero329 and others added 7 commits September 11, 2020 08:25
@omero329 @joaquinelio
Update 2-ui/2-events/04-default-browser-action/article.md
c17b5f6 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329 @joaquinelio
Update 2-ui/2-events/04-default-browser-action/article.md
91cf14a 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329
'Entonces','de inmediato'
41f89c1
@omero329 @joaquinelio
Update 2-ui/2-events/04-default-browser-action/1-why-return-false-fai…
9389b69 
…ls/solution.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329 @joaquinelio
Update 2-ui/2-events/04-default-browser-action/2-catch-link-navigatio…
52bdeda 
…n/solution.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329 @joaquinelio
Update 2-ui/2-events/04-default-browser-action/3-image-gallery/source…
febee0a 
….view/index.html

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329
Merge branch 'Browser-default-actions' of https://github.com/homero30…
9bd14bd 
…4/es.javascript.info into Browser-default-actions
@homero304
Copy link
Contributor Author

/done

joaquinelio
joaquinelio requested changes Sep 12, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¿me disculpas que haya agregado mas cosas? de estilo tambien

salvo un acento faltante que note haciendo zoom

2-ui/2-events/04-default-browser-action/article.md Outdated Show resolved Hide resolved
2-ui/2-events/04-default-browser-action/2-catch-link-navigation/task.md Outdated Show resolved Hide resolved
2-ui/2-events/04-default-browser-action/article.md Outdated Show resolved Hide resolved
2-ui/2-events/04-default-browser-action/article.md Outdated Show resolved Hide resolved
2-ui/2-events/04-default-browser-action/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

omero329 and others added 5 commits September 12, 2020 10:45
@omero329 @joaquinelio
Update 2-ui/2-events/04-default-browser-action/article.md
b79e278 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329 @joaquinelio
Update 2-ui/2-events/04-default-browser-action/2-catch-link-navigatio…
f074459 
…n/task.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329 @joaquinelio
Update 2-ui/2-events/04-default-browser-action/article.md
b18160b 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329 @joaquinelio
Update 2-ui/2-events/04-default-browser-action/article.md
95bda95 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329 @joaquinelio
Update 2-ui/2-events/04-default-browser-action/article.md
ae338c5 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@homero304
Copy link
Contributor Author

/done

joaquinelio
joaquinelio approved these changes Sep 12, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

vplentinax
vplentinax approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bien!

@joaquinelio joaquinelio merged commit 5d87fd8 into javascript-tutorial:master Sep 15, 2020
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes

@vplentinax vplentinax vplentinax approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@homero304 @javascript-translate-bot @joaquinelio @vplentinax @omero329