Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blob #380

Merged
merged 2 commits into from
Sep 17, 2020
Merged

Blob #380

merged 2 commits into from
Sep 17, 2020

Conversation

kenliten
Copy link
Contributor

No description provided.

joaquinelio
joaquinelio requested changes Sep 16, 2020
View reviewed changes
4-binary/03-blob/article.md Outdated Show resolved Hide resolved
4-binary/03-blob/article.md Outdated Show resolved Hide resolved
4-binary/03-blob/article.md Outdated Show resolved Hide resolved
4-binary/03-blob/article.md Outdated Show resolved Hide resolved
4-binary/03-blob/article.md Outdated Show resolved Hide resolved
4-binary/03-blob/article.md Outdated Show resolved Hide resolved
4-binary/03-blob/article.md Outdated Show resolved Hide resolved
4-binary/03-blob/article.md Outdated Show resolved Hide resolved
4-binary/03-blob/article.md Outdated Show resolved Hide resolved
4-binary/03-blob/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@joaquinelio joaquinelio changed the title Translated Blob article Blob Sep 16, 2020
@joaquinelio
Copy link
Member

si ponemos el titulo exacto del pr,
el bot lo añade el issue17, y al hacer merge lo marca hecho

no big deal, lo actualizamos a mano.

@joaquinelio joaquinelio mentioned this pull request Sep 16, 2020
Open
@joaquinelio
Apply suggestions from code review
a29c5ef 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@kenliten
Copy link
Contributor Author

/done

vplentinax
vplentinax approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@joaquinelio joaquinelio merged commit 0e6845b into javascript-tutorial:master Sep 17, 2020
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes

@vplentinax vplentinax vplentinax approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kenliten @javascript-translate-bot @joaquinelio @vplentinax