Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript animations #389

Merged

Conversation

homero304
Copy link
Contributor

please review my PR

Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esta perfecto
nimiedades si queres cambiar puse suggest,
cambies o no ok para online

7-animation/3-js-animation/article.md Outdated Show resolved Hide resolved
7-animation/3-js-animation/article.md Outdated Show resolved Hide resolved
7-animation/3-js-animation/article.md Outdated Show resolved Hide resolved

Surely we could improve it, add more bells and whistles, but JavaScript animations are not applied on a daily basis. They are used to do something interesting and non-standard. So you'd want to add the features that you need when you need them.
Seguramente podríamos mejorarlo, agregar más campanas y silbidos, pero las animaciones de JavaScript no se aplican a diario. Se utilizan para hacer algo interesante y no estándar. Por lo tanto, querrás agregar las funciones que necesitas cuando las necesites.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

estaria bien...
pero es expresion muy usada que se pierde traducida
agregar mas...
...fanfarria, barroco , trompetas y bombos...
no tengo sugerencia sorry :-P
y menos que no sea regional

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no se que ponerle tampoco X.X creo que la dejare asi..

7-animation/3-js-animation/article.md Outdated Show resolved Hide resolved
Homero Enrique Marin Galindo and others added 6 commits September 28, 2020 04:19
Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oki

@joaquinelio joaquinelio merged commit 095fb6f into javascript-tutorial:master Oct 2, 2020
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

@joaquinelio
Copy link
Member

joaquinelio commented Oct 2, 2020

@homero304
ah...
es algo que añadimos, silvidos es dificil de añadir
agregarle "pitos/silbatos y campanas" al programa era mas razonable, jaja
tarde
pero NO importa
no voy a hacer un pr para eso

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants