Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rest parameters and spread syntax #142

Merged
merged 24 commits into from
Sep 2, 2021

Conversation

Amirhossein-Veysi
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Aug 31, 2021

CLA assistant check
All committers have signed the CLA.

@mahdyar
Copy link
Member

mahdyar commented Sep 1, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Hello @Amirhossein-Veysi and thank you for your contribution;
You should first sign the CLA before I can review your translation, so I mark this as draft since it's not yet ready to be reviewed.
Feel free to mark it as "Ready for review" whenever it was ready. :)

@mahdyar mahdyar marked this pull request as draft September 1, 2021 07:35
@Amirhossein-Veysi Amirhossein-Veysi marked this pull request as ready for review September 1, 2021 09:07
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@Amirhossein-Veysi
Copy link
Contributor Author

Hi, Thanks for your review @mahdyar, I tried to solve all problems and now there's no problem, there might be some issue in preview and the reason is the line 122 which wraps the rest of the lines in a code section.
/done

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@Amirhossein-Veysi
Copy link
Contributor Author

The issue resolved. /done

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@Amirhossein-Veysi
Copy link
Contributor Author

Amirhossein-Veysi commented Sep 2, 2021

Should i replace commas in the commented section of codes that are translated? @mahdyar

@mahdyar
Copy link
Member

mahdyar commented Sep 2, 2021

Should i replace commas in the commented section of codes that are translated? @mahdyar

It's up to you, but I wouldn't.

@Amirhossein-Veysi
Copy link
Contributor Author

/done

Copy link
Member

@mahdyar mahdyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Amirhossein-Veysi!

@mahdyar mahdyar merged commit dff1c54 into javascript-tutorial:master Sep 2, 2021
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants