Property getters and setters #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lines 107 to 110 were started from left, because there were English words in the beginning, and they didn't look nice. I added Persian words in the beginning, so the lines start from right.
Line 188 needs more attention
mahdiHash
commented
Nov 11, 2021
mahdyar
requested changes
Nov 11, 2021
|
Please make the requested changes. After it, add a comment "/done". |
Co-authored-by: Mahdyar Hasanpour <thisismahdyar@gmail.com> Replaced «گیرنده» with "getter" Replaced «تنظیمکننده» with "setter" Replaced «دسترسی» with «اکسسر» And some small changes: - Fixed a typo in line 203 - Also changed a word in lines 108 and 143
|
Thank you @mahdyar |
mahdyar
approved these changes
Nov 12, 2021
|
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review and comment/commit if anything is wrong