Class inheritance #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mahdyar merged 13 commits into javascript-tutorial:master from mahdiHash:master

Dec 7, 2021

Contributor

mahdiHash commented Dec 4, 2021

Please review and comment/commit if anything is wrong.

mahdiHash added 10 commits

November 29, 2021 13:37


          Translate a part of article

b742642


          Translate a part of article

Lines 98 and 171 need more attention


          Change 2 lines for better readability

bc41483


          Translate a part of article

380807d

Lines 235 and 241 need more attention.


          Translate a part of article

6e0b9cf


          Translate a part of article

f7f1234

Line 441 needs more attention


          Translate a part of article

82c24c8

Line 499 needs more attention


          Translate a part of article

1713e48

Line 582 needs more attention (translation of "duplication")


          Translate article

7afc120


          Merge branch 'master' of https://github.com/mahdihashemi14/fa.javascr…

147fa27

…ipt.info

javascript-translate-bot added the review needed label

javascript-translate-bot requested a review from a team

December 4, 2021 14:37

javascript-translate-bot mentioned this pull request

Persian (Farsi) Translation Progress #1

Open

mahdiHash added 2 commits

December 4, 2021 18:12


          Translate "class-constructor-error" task and solution

0e6b758


          Translate "clock-class-extended" task and solution

91548f6

mahdiHash commented

View reviewed changes

1-js/09-classes/02-class-inheritance/article.md Show resolved Hide resolved

mahdiHash commented

View reviewed changes

1-js/09-classes/02-class-inheritance/article.md Show resolved Hide resolved

mahdiHash commented

View reviewed changes

1-js/09-classes/02-class-inheritance/article.md Show resolved Hide resolved

mahdiHash commented

View reviewed changes

1-js/09-classes/02-class-inheritance/article.md Outdated Show resolved Hide resolved

mahdiHash commented

View reviewed changes

1-js/09-classes/02-class-inheritance/article.md Show resolved Hide resolved

mahdiHash commented

View reviewed changes

1-js/09-classes/02-class-inheritance/article.md Show resolved Hide resolved

mahdiHash commented

View reviewed changes

1-js/09-classes/02-class-inheritance/article.md Show resolved Hide resolved

mahdiHash marked this pull request as ready for review

December 4, 2021 14:54

mahdyar requested changes

View reviewed changes

Member

mahdyar left a comment

Please review the suggestions.

javascript-translate-bot added changes requested and removed review needed labels

javascript-translate-bot commented Dec 6, 2021

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻


          Change "شناختن" to "رفع‌کردن" as the translation of "resolve"

2b24eee

Contributor Author

mahdiHash commented Dec 6, 2021

Thank you @mahdyar
/done

javascript-translate-bot removed the changes requested label

javascript-translate-bot added the review needed label

javascript-translate-bot requested a review from a team

December 6, 2021 10:57

mahdyar approved these changes

View reviewed changes

Member

mahdyar left a comment

Thank you, @mahdiHashemi14!

mahdyar merged commit be4b110 into javascript-tutorial:master

javascript-translate-bot commented Dec 7, 2021

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

javascript-translate-bot added needs +1 and removed review needed labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels