Skip to content

Switch #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 15, 2020
Merged

Switch #61

merged 6 commits into from
Jul 15, 2020

Conversation

newshahn
Copy link
Contributor

Hi,
Switch chapter was translated :)

@javascript-translate-bot javascript-translate-bot requested a review from a team July 12, 2020 12:01
mehradsadeghi
mehradsadeghi reviewed Jul 12, 2020
View reviewed changes
mehradsadeghi
mehradsadeghi reviewed Jul 12, 2020
View reviewed changes
mehradsadeghi
mehradsadeghi suggested changes Jul 12, 2020
View reviewed changes
Copy link
Contributor

@mehradsadeghi mehradsadeghi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are multiple parts that you've changed single quotes to double quotes in the translations (in code sections). Is there any reason for that ? Am I missing something ?

@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@newshahn
Copy link
Contributor Author

As you can probably tell, I'm pretty new to programming and Github and that's partly why I made these mistakes.
I will fix them and resend my PR.
Thank you

@mehradsadeghi
Copy link
Contributor

As you can probably tell, I'm pretty new to programming and Github and that's partly why I made these mistakes.
I will fix them and resend my PR.
Thank you

Don't worry about it. You're doing fine.

@newshahn
Copy link
Contributor Author

Dear Mehrad,
I fixed the issues you mentioned in the past PR.
An extension was changing my double quotes to single quotes.
Hopefully, it's all okay now.

mehradsadeghi
mehradsadeghi approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@mehradsadeghi mehradsadeghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

@mehradsadeghi mehradsadeghi merged commit 74cdde6 into javascript-tutorial:master Jul 15, 2020
@mahdyar mahdyar mentioned this pull request Apr 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mehradsadeghi mehradsadeghi mehradsadeghi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@newshahn @javascript-translate-bot @mehradsadeghi