Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event delegation #203

Merged
merged 14 commits into from
Feb 9, 2021
Merged

Conversation

pierangelomiceli
Copy link
Contributor

No description provided.

@longo-andrea
Copy link
Contributor

@pierangelomiceli intanto correggo l'articolo, manca però la traduzione degli esercizi e delle soluzioni

Copy link
Contributor

@longo-andrea longo-andrea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ho fatto solamente un check dei typos, dopo leggo l'articolo e ti do un feedback più dettagliato

2-ui/2-events/03-event-delegation/article.md Outdated Show resolved Hide resolved
Co-authored-by: Andrea  <45577511+longo-andrea@users.noreply.github.com>
2-ui/2-events/03-event-delegation/article.md Outdated Show resolved Hide resolved
2-ui/2-events/03-event-delegation/article.md Outdated Show resolved Hide resolved
Chiarimenti:
1. Il metodo `elem.closest(selector)` ritorna l'antenato più vicino che combacia con il selettore. Nel nostro caso cerchiamo un `<td>` verso l'alto dall'elemento di origine dell'evento.
2. Se `event.target` non è dentro nessun `<td>`, la chiamata esce immediatamente, dal momento che non c'è nulla da fare.
3. Ne caso di tabelle annidate, `event.target` potrebbe essere un `<td>`, ma fuori dalla tabelle corrente. Quindi andiamo a controllare se sia il `<td>` della *nostra tabella*.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. Ne caso di tabelle annidate, `event.target` potrebbe essere un `<td>`, ma fuori dalla tabelle corrente. Quindi andiamo a controllare se sia il `<td>` della *nostra tabella*.
3. Nel caso di tabelle annidate, `event.target` potrebbe essere un `<td>`, ma fuori dalla tabelle corrente. Quindi andiamo a controllare se sia il `<td>` della *nostra tabella*.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/done

2-ui/2-events/03-event-delegation/article.md Outdated Show resolved Hide resolved
2-ui/2-events/03-event-delegation/article.md Outdated Show resolved Hide resolved
2-ui/2-events/03-event-delegation/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

pierangelomiceli and others added 5 commits February 6, 2021 23:07
Co-authored-by: Andrea  <45577511+longo-andrea@users.noreply.github.com>
Co-authored-by: Andrea  <45577511+longo-andrea@users.noreply.github.com>
Co-authored-by: Andrea  <45577511+longo-andrea@users.noreply.github.com>
Co-authored-by: Andrea  <45577511+longo-andrea@users.noreply.github.com>
Co-authored-by: Andrea  <45577511+longo-andrea@users.noreply.github.com>
@longo-andrea
Copy link
Contributor

Gli esercizi tradotti sono nella PR #205

Copy link
Member

@pasor1 pasor1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qualche pioccola nota

2-ui/2-events/03-event-delegation/article.md Outdated Show resolved Hide resolved
2-ui/2-events/03-event-delegation/article.md Outdated Show resolved Hide resolved
2-ui/2-events/03-event-delegation/article.md Outdated Show resolved Hide resolved
2-ui/2-events/03-event-delegation/article.md Outdated Show resolved Hide resolved
2-ui/2-events/03-event-delegation/article.md Outdated Show resolved Hide resolved
2-ui/2-events/03-event-delegation/article.md Outdated Show resolved Hide resolved
2-ui/2-events/03-event-delegation/article.md Outdated Show resolved Hide resolved
pierangelomiceli and others added 7 commits February 9, 2021 20:08
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@longo-andrea longo-andrea merged commit 8aeeedb into javascript-tutorial:master Feb 9, 2021
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants