Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prototypal inheritance #207

Merged
merged 4 commits into from
Feb 11, 2021
Merged

Prototypal inheritance #207

merged 4 commits into from
Feb 11, 2021

Conversation

longo-andrea
Copy link
Contributor

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team February 7, 2021 17:23
@javascript-translate-bot javascript-translate-bot mentioned this pull request Feb 7, 2021
Open
Dorin-David
Dorin-David suggested changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@Dorin-David Dorin-David left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ho proposto alcune piccole modifiche. Per il resto, gran traduzione!

@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@longo-andrea @Dorin-David
Apply suggestions from code review
efec4c1 
Co-authored-by: Dorin-David <70648503+Dorin-David@users.noreply.github.com>
@longo-andrea
Copy link
Contributor Author

/done

pasor1
pasor1 approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@pasor1 pasor1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solo qualche piccola correzione

1-js/08-prototypes/01-prototype-inheritance/4-hamster-proto/solution.md Outdated Show resolved Hide resolved
1-js/08-prototypes/01-prototype-inheritance/4-hamster-proto/task.md Outdated Show resolved Hide resolved
1-js/08-prototypes/01-prototype-inheritance/article.md Outdated Show resolved Hide resolved
1-js/08-prototypes/01-prototype-inheritance/article.md Outdated Show resolved Hide resolved
1-js/08-prototypes/01-prototype-inheritance/article.md Outdated Show resolved Hide resolved
1-js/08-prototypes/01-prototype-inheritance/article.md Outdated Show resolved Hide resolved
@longo-andrea @pasor1
Apply suggestions from code review
a05ed54 
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@longo-andrea longo-andrea merged commit 25dbab4 into javascript-tutorial:master Feb 11, 2021
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@longo-andrea longo-andrea deleted the article/01-prototype-inheritance branch March 7, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorin-David Dorin-David Dorin-David requested changes

@pasor1 pasor1 pasor1 approved these changes

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@longo-andrea @javascript-translate-bot @pasor1 @Dorin-David