Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prototype methods, objects without __proto__ #213

Merged
merged 2 commits into from
Feb 22, 2021
Merged

Prototype methods, objects without __proto__ #213

merged 2 commits into from
Feb 22, 2021

Conversation

longo-andrea
Copy link
Contributor

No description provided.

@javascript-translate-bot javascript-translate-bot mentioned this pull request Feb 13, 2021
Open
Dorin-David
Dorin-David reviewed Feb 22, 2021
View reviewed changes
1-js/08-prototypes/04-prototype-methods/article.md

All methods that return object properties (like `Object.keys` and others) -- return "own" properties. If we want inherited ones, we can use `for..in`.
Tutti i metodi che ritornano le proprietà di un oggetto (come `Object.keys` e le altre) -- ritornano le proprietà "possedute". Se vogliamo ottenere anche le proprietà ereditate dobbiamo utilizzare un ciclo `for..in`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Tutti i metodi che ritornano le proprietà di un oggetto (come `Object.keys` e le altre) -- ritornano le proprietà "possedute". Se vogliamo ottenere anche le proprietà ereditate dobbiamo utilizzare un ciclo `for..in`.
Tutti i metodi che ritornano le proprietà di un oggetto (come `Object.keys` e le altre) -- ritornano le proprietà scritte nell'oggetto stesso. Se vogliamo ottenere anche le proprietà ereditate dobbiamo utilizzare un ciclo `for..in`.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Secondo me qui "possedute" va bene, serve a far capire bene che non si parla di tutte le proprietà, ma solo di quelle non ereditate.

Dorin-David
Dorin-David suggested changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@Dorin-David Dorin-David left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ottima traduzione! Ho suggerito un paio di modifiche

@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

pasor1
pasor1 approved these changes Feb 22, 2021
View reviewed changes
1-js/08-prototypes/04-prototype-methods/2-dictionary-tostring/solution.md Outdated Show resolved Hide resolved
1-js/08-prototypes/04-prototype-methods/2-dictionary-tostring/task.md Outdated Show resolved Hide resolved
1-js/08-prototypes/04-prototype-methods/article.md Outdated Show resolved Hide resolved
1-js/08-prototypes/04-prototype-methods/article.md

All methods that return object properties (like `Object.keys` and others) -- return "own" properties. If we want inherited ones, we can use `for..in`.
Tutti i metodi che ritornano le proprietà di un oggetto (come `Object.keys` e le altre) -- ritornano le proprietà "possedute". Se vogliamo ottenere anche le proprietà ereditate dobbiamo utilizzare un ciclo `for..in`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Secondo me qui "possedute" va bene, serve a far capire bene che non si parla di tutte le proprietà, ma solo di quelle non ereditate.

@longo-andrea @Dorin-David @pasor1
Apply suggestions from code review
ec3bdcc 
Co-authored-by: Dorin-David <70648503+Dorin-David@users.noreply.github.com>
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@longo-andrea longo-andrea merged commit cb2fa2e into javascript-tutorial:master Feb 22, 2021
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@longo-andrea longo-andrea deleted the article/prototype-methods branch March 7, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorin-David Dorin-David Dorin-David requested changes

@pasor1 pasor1 pasor1 approved these changes

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@longo-andrea @javascript-translate-bot @pasor1 @Dorin-David