Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private and protected properties and method #240

Merged
merged 5 commits into from
Mar 7, 2021
Merged

Private and protected properties and method #240

merged 5 commits into from
Mar 7, 2021

Conversation

longo-andrea
Copy link
Contributor

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team March 5, 2021 21:29
@longo-andrea longo-andrea mentioned this pull request Mar 6, 2021
Open
Dorin-David
Dorin-David suggested changes Mar 6, 2021
View reviewed changes
Copy link
Contributor

@Dorin-David Dorin-David left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ho suggerito alcune modifiche

@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@longo-andrea @Dorin-David
Apply suggestions from code review
e859b82 
Co-authored-by: Dorin David <70648503+Dorin-David@users.noreply.github.com>
@longo-andrea
Copy link
Contributor Author

/done

@longo-andrea
Copy link
Contributor Author

Ho aggiunto qui la traduzione del titolo del capitolo, mi ero completamente dimenticato 😅

pasor1
pasor1 requested changes Mar 7, 2021
View reviewed changes
1-js/09-classes/04-private-protected-properties-methods/article.md Outdated Show resolved Hide resolved
1-js/09-classes/04-private-protected-properties-methods/article.md Outdated Show resolved Hide resolved
1-js/09-classes/04-private-protected-properties-methods/article.md Outdated Show resolved Hide resolved
1-js/09-classes/04-private-protected-properties-methods/article.md Outdated Show resolved Hide resolved
1-js/09-classes/04-private-protected-properties-methods/article.md Outdated Show resolved Hide resolved
1-js/09-classes/04-private-protected-properties-methods/article.md Outdated Show resolved Hide resolved
1-js/09-classes/04-private-protected-properties-methods/article.md Outdated Show resolved Hide resolved
1-js/09-classes/04-private-protected-properties-methods/article.md Outdated Show resolved Hide resolved
1-js/09-classes/04-private-protected-properties-methods/article.md Outdated Show resolved Hide resolved
1-js/09-classes/04-private-protected-properties-methods/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@longo-andrea @pasor1
Apply suggestions from code review
23ca259 
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@longo-andrea
Copy link
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team March 7, 2021 14:56
@pasor1 pasor1 merged commit 86f5d0a into javascript-tutorial:master Mar 7, 2021
@longo-andrea longo-andrea deleted the article/private-protected-methods branch March 7, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorin-David Dorin-David Dorin-David requested changes

@pasor1 pasor1 pasor1 approved these changes

Assignees
No one assigned
Labels
needs +1 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@longo-andrea @javascript-translate-bot @pasor1 @Dorin-David