Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard: keydown and keyup #265

Merged
merged 6 commits into from
Mar 24, 2021
Merged

Keyboard: keydown and keyup #265

merged 6 commits into from
Mar 24, 2021

Conversation

pierangelomiceli
Copy link
Contributor

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team March 15, 2021 14:55
@javascript-translate-bot javascript-translate-bot mentioned this pull request Mar 15, 2021
Open
Dorin-David
Dorin-David reviewed Mar 19, 2021
View reviewed changes
Copy link
Contributor

@Dorin-David Dorin-David left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ottima traduzione Pier! Mi sono permesso di suggerire alcune piccole modifiche, fanne quello che vuoi.

@pierangelomiceli @Dorin-David
Apply suggestions from code review
a31e083 
Co-authored-by: Dorin David <70648503+Dorin-David@users.noreply.github.com>
@pierangelomiceli
Copy link
Contributor Author

/done

@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@longo-andrea
Copy link
Contributor

visto che è aperta da oltre una settimana, prendo io in carico le modifiche suggerite cosi poi è pronta per il merge

@longo-andrea @pasor1
Apply suggestions from code review
9f1aad1 
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@longo-andrea
Copy link
Contributor

/done

@pierangelomiceli
Copy link
Contributor Author

potete fare merge quando volete.

@pasor1 pasor1 merged commit 60f5c83 into javascript-tutorial:master Mar 24, 2021
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorin-David Dorin-David Dorin-David left review comments

@pasor1 pasor1 pasor1 approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pierangelomiceli @javascript-translate-bot @longo-andrea @pasor1 @Dorin-David