Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross-window communication #273

Merged
merged 7 commits into from
Apr 5, 2021
Merged

Cross-window communication #273

merged 7 commits into from
Apr 5, 2021

Conversation

longo-andrea
Copy link
Contributor

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team March 25, 2021 21:02
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ longo-andrea
❌ Andrea Longo

Andrea Longo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@longo-andrea longo-andrea changed the title Article/cross window Cross-window communication Mar 25, 2021
@longo-andrea longo-andrea mentioned this pull request Mar 25, 2021
Open
Dorin-David
Dorin-David reviewed Apr 3, 2021
View reviewed changes
Copy link
Contributor

@Dorin-David Dorin-David left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bella traduzione! Ti ho lasciato un paio di suggerimenti, fanne quello che vuoi

@longo-andrea @Dorin-David
Apply suggestions from code review
003415a 
Co-authored-by: Dorin David <70648503+Dorin-David@users.noreply.github.com>
pasor1
pasor1 approved these changes Apr 5, 2021
View reviewed changes
3-frames-and-windows/03-cross-window-communication/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/03-cross-window-communication/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/03-cross-window-communication/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/03-cross-window-communication/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/03-cross-window-communication/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/03-cross-window-communication/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/03-cross-window-communication/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/03-cross-window-communication/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/03-cross-window-communication/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/03-cross-window-communication/article.md Outdated Show resolved Hide resolved
@longo-andrea @pasor1
Apply suggestions from code review
eab7f57 
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@longo-andrea longo-andrea merged commit 2ce86d8 into javascript-tutorial:master Apr 5, 2021
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@longo-andrea longo-andrea deleted the article/cross-window branch April 10, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorin-David Dorin-David Dorin-David left review comments

@pasor1 pasor1 pasor1 approved these changes

Assignees
No one assigned
Labels
2nd review done needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@longo-andrea @CLAassistant @javascript-translate-bot @pasor1 @Dorin-David