Use HTTPS when communicating with harmonyremote.com #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, Logitech enabled HTTPS on the members.harmonyremote.com website and implemented automatic redirects from HTTP -> HTTPS. Unfortunately, this broke our relatively simple HTTP client as it understood neither redirects nor HTTPS. Resolve this situation by replacing our HTTP client with libcurl. Although this adds a new dependency, this seems much simpler than trying to implement & maintain the relevant OpenSSL (or other SSL library) calls to perform HTTPS (which would also require other dependencies anyway) and also reduces the codebase slightly.
jaymzh
requested changes
Jan 22, 2022
jaymzh
approved these changes
Jan 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, Logitech enabled HTTPS on the members.harmonyremote.com
website and implemented automatic redirects from HTTP -> HTTPS.
Unfortunately, this broke our relatively simple HTTP client as it
understood neither redirects nor HTTPS. Resolve this situation by
replacing our HTTP client with libcurl. Although this adds a new
dependency, this seems much simpler than trying to implement & maintain the
relevant OpenSSL (or other SSL library) calls to perform HTTPS (which
would also require other dependencies anyway) and also reduces the
codebase slightly.