Additional functional maps for GeoJSON entities #109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me, but any chance you could fix the flake8 issues that travis ci found? |
Closed
Merged
|
Close this now that #112 is merged, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for map_coords hints that it should be usable for coordinate transforms and the like, but the actual implementation only calls with individual values. So rather than
Point(x, y, z) => func(Point(x, y, z))You get
Point(x, y, z) => Point(func(x), func(y), func(z))In my experience, this isn't a very useful transform. This PR adds map_tuples (rather than map_coords to preserve compatibility) for the former use case, and map_geometries for use cases like doing a spatial intersection.