Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PR #109. #112

Merged
merged 4 commits into from
May 22, 2018
Merged

Fix PR #109. #112

merged 4 commits into from
May 22, 2018

Conversation

JanLikar
Copy link
Contributor

Fix tests to make #109 mergeable.

@JanLikar
Copy link
Contributor Author

Please, keep in mind: I'm not completely familiar with the codebase, so I cannot be confident @jlaxson's code is correct. I merely fixed flake8 issues and a couple of obvious bugs.

@codecov-io
Copy link

codecov-io commented May 16, 2018 •
edited
Loading

Codecov Report

Merging #112 into master will decrease coverage by 3.67%.
The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #112      +/-   ##
=========================================
- Coverage   96.17%   92.5%   -3.68%     
=========================================
  Files          11      11              
  Lines         340     360      +20     
  Branches       59      67       +8     
=========================================
+ Hits          327     333       +6     
- Misses          7      17      +10     
- Partials        6      10       +4
Impacted Files Coverage Δ
geojson/utils.py 81.18% <45.45%> (-12.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c2b6fe...6ec6aaf. Read the comment docs.

@JanLikar JanLikar mentioned this pull request May 16, 2018
Closed
@frewsxcv
Copy link
Collaborator

bors r+

bors bot added a commit that referenced this pull request May 22, 2018
@bors @jlaxson @JanLikar
Merge #112
05d0cdd 
112: Fix PR #109. r=frewsxcv a=JanLikar

Fix tests to make #109 mergeable.

Co-authored-by: John Laxson <jlaxson@mac.com>
Co-authored-by: Jan Likar <jan.likar@protonmail.com>
@bors
Copy link
Contributor

bors bot commented May 22, 2018

Build succeeded

@bors bors bot merged commit 6ec6aaf into jazzband:master May 22, 2018
@notriddle notriddle mentioned this pull request May 22, 2018
Closed
@JanLikar JanLikar deleted the fix-utils-map-coords branch May 22, 2018 15:35
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Nov 10, 2018
@kleink
Update py-geojson to 2.4.1
a587bfe 
2.4.1 (2018-10-17)
------------------

- Allow ``FeatureCollections`` to be passed to ``coords``

  - jazzband/geojson#117

2.4.0 (2018-05-21)
------------------

- Additional functional maps for GeoJSON entities

  - jazzband/geojson#112
@pyup-bot pyup-bot mentioned this pull request Jun 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JanLikar @codecov-io @frewsxcv @jlaxson