Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of pip 18.1 #689

Merged
merged 1 commit into from Oct 5, 2018
Merged

Conversation

vphilippon
Copy link
Member

@vphilippon vphilippon commented Oct 5, 2018

Added shims for the move of InstallRequirement.from_line andInstallRequirement.from_editable to
constructors.install_req_from_line and constructors.install_req_from_editable.

Fixes #688

Changelog-friendly one-liner: Added support of pip 18.1.

Contributor checklist
  • Provided the tests for the changes
  • Requested (or received) a review from another contributor
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md afterwards).

@vphilippon vphilippon added this to the 3.1.0 milestone Oct 5, 2018
@vphilippon
Copy link
Member Author

@techalchemy If you'd like to review, please do!

@helpse
Copy link

helpse commented Oct 5, 2018

PLEASE merge it!

Added shims for the move of `InstallRequirement.from_line` and
`InstallRequirement.from_editable` to
`constructors.install_req_from_line` and
`constructors.install_req_from_editable`.

Fixes jazzband#688
@vphilippon vphilippon merged commit 40c19b2 into jazzband:master Oct 5, 2018
@vphilippon vphilippon deleted the pip-18.1-support branch October 5, 2018 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants