pip-compile quiet with empty changes #739
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #739 +/- ##
==========================================
- Coverage 85.96% 85.88% -0.09%
==========================================
Files 31 31
Lines 2124 2126 +2
Branches 304 305 +1
==========================================
Hits 1826 1826
- Misses 232 234 +2
Partials 66 66
Continue to review full report at Codecov.
|
atugushev
requested changes
Feb 22, 2019
| @@ -125,7 +125,9 @@ def sync(to_install, to_uninstall, verbose=False, dry_run=False, pip_flags=None, | |||
| Install and uninstalls the given sets of modules. | |||
| """ | |||
| if not to_uninstall and not to_install: | |||
| click.echo("Everything up-to-date") | |||
| if not verbose: | |||
There was a problem hiding this comment.
If not verbose - be verbose. Sounds kind of meaningless.
|
Closed in favour of #765. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #627
Changelog-friendly one-liner: <!--- One-liner description here --->
Contributor checklist