-
-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed pip-compile --upgrade-package removes "via" annotation #931
Conversation
Hello @hramezani, Thanks for fixing this bug and the test! Could you use current PR template if the changes are user-facing, for it might need a changelog entry? Thanks! |
@atugushev Thanks for the comment. Description edited. |
Codecov Report
@@ Coverage Diff @@
## master #931 +/- ##
==========================================
+ Coverage 99.09% 99.09% +<.01%
==========================================
Files 35 35
Lines 2321 2331 +10
Branches 300 301 +1
==========================================
+ Hits 2300 2310 +10
Misses 13 13
Partials 8 8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! A few nit-pickings below 🤓
Thanks for addressing to my request changes, i've marked all conversations as resolved! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Thanks for your excellent work and your patience, @hramezani! |
Fixes #929.
Changelog-friendly one-liner: Fixed
pip-compile --upgrade-package
removes "via" annotation.Contributor checklist