-
-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix --trusted-host is not copied from *.in to *.txt #964
Fix --trusted-host is not copied from *.in to *.txt #964
Conversation
Codecov Report
@@ Coverage Diff @@
## master #964 +/- ##
==========================================
+ Coverage 99.18% 99.19% +<.01%
==========================================
Files 35 35
Lines 2338 2358 +20
Branches 301 303 +2
==========================================
+ Hits 2319 2339 +20
Misses 11 11
Partials 8 8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked over code and confirmed it works as expected locally.
Oh yeah... thanks! |
Keep consistent the return type. Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Fix the docstring to be precise. Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
I believe the have been more than enough reviews. So I am going to save myselthe trouble, ok? |
@webknjaz thanks for taking the time reviewing this! All request changes seem resolved, are we okay with this or are there any other issues? |
@webknjaz @nasirhjafri @altendky thanks for reviewing this! 🎉 |
Fixes #963.
Changelog-friendly one-liner: Fix
pip-compile
doesn't copy--trusted-host
fromrequirements.in
torequirements.txt
.Contributor checklist